Files
HarborForge.PlexumPlugin/internal/tools/tools.go
hzhang 78b1ec5181 fix: align calendar API with actual HarborForge.Backend contract
Initial drop guessed the heartbeat shape; sim e2e against a running
harborforge-backend revealed the real contract is per-agent with
header auth, not server-wide with bearer:

  POST /calendar/agent/heartbeat
    headers: X-Agent-ID, X-Claw-Identifier
    body:    {claw_identifier, agent_id}
    response: {slots: [Slot], agent_status, message?}

  PATCH /calendar/slots/{id}/agent-update
  PATCH /calendar/slots/virtual/{vid}/agent-update
    body: {status, started_at?, actual_duration?}

  POST /calendar/agent/status
    body: {claw_identifier, agent_id, status}

Refactors:

  - internal/calendar/types.go now mirrors OpenclawPlugin/calendar/
    types.ts 1:1 (SlotStatus camelCase, real vs virtual slot id
    discrimination, event_data shape)
  - internal/calendar/bridge.go: header-based auth, per-agent method
    signatures, separate UpdateRealSlot vs UpdateVirtualSlot
  - internal/calendar/scheduler.go: per-agent heartbeat loop
    (one HTTP call per agent per tick), highest-priority slot
    selection, agent-update PATCH for terminal/non-terminal states
  - SingleActiveAgentID helper for main.bestEffortAgentID

Also fix two bugs found in sim:

  - bgCtx capture: AgentLister closures were capturing Init's ctx
    which dies the moment MCP initialize returns; switched to
    bgCtx (lifetime = plugin process)
  - tools.toolRestartStatus referenced a non-existent
    sch.RestartPending — HF backend has no restart endpoint per
    /openapi.json, so the tool now reports last_heartbeats freshness

Scheduler logs each tick + each heartbeat outcome at info so
operators can see backend connectivity without enabling debug.

E2E against http://harborforge-backend:8000 in sim:
  daemon → heartbeat → 404 "Agent not found"
  (= correct endpoint, correct headers, correct body — agent just
   isn't registered yet, which is expected for an untenanted
   plugin)
2026-06-03 11:28:05 +01:00

218 lines
7.0 KiB
Go

// Package tools wires the 9 harborforge_* tool implementations to
// the plugin's runtime state (config, telemetry collector, monitor
// bridge, calendar scheduler). Each tool is a CallTool dispatch
// branch in main.go's plugin; this package holds the shared logic.
package tools
import (
"context"
"encoding/json"
"errors"
"fmt"
"strings"
"time"
sdkplugin "git.hangman-lab.top/hzhang/Plexum-sdk-go/plugin"
"git.hangman-lab.top/zhi/HarborForge.PlexumPlugin/internal/calendar"
"git.hangman-lab.top/zhi/HarborForge.PlexumPlugin/internal/config"
"git.hangman-lab.top/zhi/HarborForge.PlexumPlugin/internal/monitor"
"git.hangman-lab.top/zhi/HarborForge.PlexumPlugin/internal/telemetry"
)
// Deps is the bundle main.go passes when constructing the tool router.
type Deps struct {
Config config.Resolved
Version string
Collect func() telemetry.Snapshot
Bridge *monitor.Bridge
Scheduler *calendar.Scheduler
Host sdkplugin.HostAPI
// AgentIDFromCtx returns the agent id the call belongs to. Plexum
// host injects this via the tool dispatch context; main.go's
// CallTool reads it from the ctx and stashes here.
AgentIDFromCtx func(ctx context.Context) string
}
// Dispatch is the entry point main.go's ToolPlugin.CallTool calls.
// Returns the canonical text response. Errors come through as
// is_error=true ToolResult rather than RPC errors so the model sees
// human-readable detail.
func Dispatch(ctx context.Context, deps Deps, name string, input json.RawMessage) (sdkplugin.ToolResult, error) {
switch name {
case "harborforge_status":
return toolStatus(deps)
case "harborforge_telemetry":
return toolTelemetry(deps)
case "harborforge_monitor_telemetry":
return toolMonitorTelemetry(deps)
case "harborforge_calendar_status":
return toolCalendarStatus(deps)
case "harborforge_calendar_complete":
return toolCalendarComplete(ctx, deps, input)
case "harborforge_calendar_abort":
return toolCalendarAbort(ctx, deps, input)
case "harborforge_calendar_pause":
return toolCalendarPause(ctx, deps, input)
case "harborforge_calendar_resume":
return toolCalendarResume(ctx, deps)
case "harborforge_restart_status":
return toolRestartStatus(deps)
}
return sdkplugin.ToolResult{
IsError: true,
Content: []sdkplugin.ContentBlock{{Type: "text", Text: "unknown tool: " + name}},
}, nil
}
func toolStatus(deps Deps) (sdkplugin.ToolResult, error) {
bs := deps.Bridge.Stats()
sch := deps.Scheduler.Status()
out := map[string]any{
"plugin": map[string]any{
"name": "harbor-forge",
"version": deps.Version,
"backend": "plexum",
},
"config": map[string]any{
"backend_url": deps.Config.BackendURL,
"identifier": deps.Config.Identifier,
"monitor_port": deps.Config.MonitorPort,
"calendar_enabled": deps.Config.CalendarEnabled,
"calendar_backendurl": deps.Config.CalendarBackendURL,
},
"monitor_bridge": map[string]any{
"listening": bs.Listening,
"port": bs.Port,
"queries": bs.Queries,
"last_query": bs.LastQuery,
},
"calendar": sch,
}
return jsonResult(out)
}
func toolTelemetry(deps Deps) (sdkplugin.ToolResult, error) {
return jsonResult(deps.Collect())
}
func toolMonitorTelemetry(deps Deps) (sdkplugin.ToolResult, error) {
bs := deps.Bridge.Stats()
return jsonResult(map[string]any{
"port": bs.Port,
"listening": bs.Listening,
"queries": bs.Queries,
"last_query": bs.LastQuery,
"last_snapshot": bs.LastSnap,
})
}
func toolCalendarStatus(deps Deps) (sdkplugin.ToolResult, error) {
return jsonResult(deps.Scheduler.Status())
}
func toolCalendarComplete(ctx context.Context, deps Deps, input json.RawMessage) (sdkplugin.ToolResult, error) {
var args struct{ Summary string `json:"summary"` }
_ = json.Unmarshal(input, &args)
agentID := deps.AgentIDFromCtx(ctx)
if agentID == "" {
return errResult("calendar_complete: no agent context")
}
if err := deps.Scheduler.CompleteForAgent(ctx, agentID, args.Summary); err != nil {
if errors.Is(err, calendar.ErrNoActiveSlot) {
return errResult("no active slot for agent " + agentID)
}
return errResult("complete failed: " + err.Error())
}
return okResult("slot marked completed")
}
func toolCalendarAbort(ctx context.Context, deps Deps, input json.RawMessage) (sdkplugin.ToolResult, error) {
var args struct{ Reason string `json:"reason"` }
_ = json.Unmarshal(input, &args)
agentID := deps.AgentIDFromCtx(ctx)
if agentID == "" {
return errResult("calendar_abort: no agent context")
}
if err := deps.Scheduler.AbortForAgent(ctx, agentID, args.Reason); err != nil {
if errors.Is(err, calendar.ErrNoActiveSlot) {
return errResult("no active slot for agent " + agentID)
}
return errResult("abort failed: " + err.Error())
}
return okResult("slot aborted")
}
func toolCalendarPause(ctx context.Context, deps Deps, input json.RawMessage) (sdkplugin.ToolResult, error) {
var args struct{ Reason string `json:"reason"` }
_ = json.Unmarshal(input, &args)
agentID := deps.AgentIDFromCtx(ctx)
if agentID == "" {
return errResult("calendar_pause: no agent context")
}
if err := deps.Scheduler.PauseForAgent(ctx, agentID, args.Reason); err != nil {
if errors.Is(err, calendar.ErrNoActiveSlot) {
return errResult("no active slot for agent " + agentID)
}
return errResult("pause failed: " + err.Error())
}
return okResult("slot paused")
}
func toolCalendarResume(ctx context.Context, deps Deps) (sdkplugin.ToolResult, error) {
agentID := deps.AgentIDFromCtx(ctx)
if agentID == "" {
return errResult("calendar_resume: no agent context")
}
if err := deps.Scheduler.ResumeForAgent(ctx, agentID); err != nil {
if errors.Is(err, calendar.ErrNoActiveSlot) {
return errResult("no active slot for agent " + agentID)
}
return errResult("resume failed: " + err.Error())
}
return okResult("slot resumed")
}
func toolRestartStatus(deps Deps) (sdkplugin.ToolResult, error) {
// HarborForge backend doesn't expose a restart-pending endpoint
// (verified via /openapi.json) so we report the most recent
// heartbeat freshness instead. Useful for operators sanity-
// checking that the plugin's calendar loop is still alive.
sch := deps.Scheduler.Status()
return jsonResult(map[string]any{
"pending": false,
"last_heartbeats": sch.LastHeartbeats,
"observed_at": time.Now().UTC(),
})
}
// ---- result helpers ----
func jsonResult(v any) (sdkplugin.ToolResult, error) {
raw, err := json.MarshalIndent(v, "", " ")
if err != nil {
return sdkplugin.ToolResult{}, fmt.Errorf("encode tool result: %w", err)
}
return sdkplugin.ToolResult{
Content: []sdkplugin.ContentBlock{{Type: "text", Text: string(raw)}},
}, nil
}
func okResult(text string) (sdkplugin.ToolResult, error) {
return sdkplugin.ToolResult{
Content: []sdkplugin.ContentBlock{{Type: "text", Text: text}},
}, nil
}
func errResult(text string) (sdkplugin.ToolResult, error) {
if !strings.HasPrefix(text, "harborforge_") {
text = "harborforge: " + text
}
return sdkplugin.ToolResult{
IsError: true,
Content: []sdkplugin.ContentBlock{{Type: "text", Text: text}},
}, nil
}