Merge pull request 'fix: wakeup message says 'continue in same session', not 'only reply WAKEUP_OK'' (#9) from fix/wakeup-message-no-ack-only into main

E2e showed the old wakeup text trapped agents in an ack-only loop:

> "You have due slots. Follow the `hf-wakeup` workflow of skill
>  `hf-hangman-lab` to proceed. Only reply `WAKEUP_OK` in this session."

The two clauses contradicted each other — "follow the workflow" vs
"only reply WAKEUP_OK". MiniMax-M2.5 prioritised the literal "only"
and never proceeded past the ack; the scheduler then re-woke every 30s
because the slot stayed `not_started`, and the agent kept re-acking
forever (verified: 3 consecutive WAKEUP_OK-only replies across slot 7).

Rewrites the wakeup message to be explicit:
  - first line MUST be `WAKEUP_OK` (the ack token the plugin looks for)
  - then continue IN THE SAME session: drive calendar_status → task
    fetch → sub-workflow → calendar_complete/abort
  - flags the loop trap so the agent knows what to avoid

Bumps version 0.3.3 → 0.3.4.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

plugin/index.ts

@@ -73,30 +73,6 @@ interface PluginAPI {
   getAgentStatus?: () => Promise<{ status: string } | null>;
 }
 
-/**
- * Coerce a tool execute() return value into the MCP `{ content: [...] }`
- * shape that the openclaw Codex tool dispatcher requires.
- *
- * Background: openclaw's `convertToolContents()` does `result.content.reduce(...)`
- * to compute total text length before flattening. Every HF tool here returned a
- * bare object (`{ running, processing, currentSlot, ... }`) which has no
- * `.content` field, so `undefined.reduce` threw and every call to
- * `harborforge_*` from a Codex-harness agent surfaced as the cryptic
- * `Cannot read properties of undefined (reading 'reduce')`. The fix is to
- * wrap every tool's execute return; doing it at the `registerTool` boundary
- * keeps each tool body unchanged.
- */
-function ensureMcpContentShape(result: unknown): { content: Array<{ type: 'text'; text: string }> } {
-  if (
-    result && typeof result === 'object' &&
-    Array.isArray((result as { content?: unknown }).content)
-  ) {
-    return result as { content: Array<{ type: 'text'; text: string }> };
-  }
-  const text = typeof result === 'string' ? result : JSON.stringify(result, null, 2);
-  return { content: [{ type: 'text', text }] };
-}
-
 function register(api: PluginAPI): void {
     const logger = api.logger || {
       info: (...args: any[]) => console.log('[HarborForge]', ...args),
@@ -105,22 +81,6 @@ function register(api: PluginAPI): void {
       warn: (...args: any[]) => console.warn('[HarborForge]', ...args),
     };
 
-    // Wrap api.registerTool so every tool's execute() return is coerced into
-    // the MCP `{ content: [...] }` shape openclaw expects. See
-    // `ensureMcpContentShape` above.
-    const _origRegisterTool = api.registerTool.bind(api);
-    api.registerTool = (factory: (ctx: any) => any) => {
-      _origRegisterTool((ctx: any) => {
-        const def = factory(ctx);
-        if (!def || typeof def.execute !== 'function') return def;
-        const origExecute = def.execute;
-        return {
-          ...def,
-          execute: async (...args: any[]) => ensureMcpContentShape(await origExecute(...args)),
-        };
-      });
-    };
-
     function resolveConfig() {
       return getPluginConfig(api);
     }
@@ -307,22 +267,21 @@ function register(api: PluginAPI): void {
           )}\n\`\`\``;
         }
 
-        // The wakeup dispatcher's `deliver` callback below only logs the
-        // reply text — it does NOT inspect any ack token. The earlier
-        // `WAKEUP_OK` first-line-ack convention was prompt-only theatre;
-        // nothing in this plugin or in openclaw acted on it. The only
-        // thing that ends a wake cycle is the slot transitioning out of
-        // `not_started`, which happens when the agent calls
-        // `harborforge_calendar_complete` or `harborforge_calendar_abort`.
-        // Tell the agent that plainly instead of asking for a fake ack.
+        // First-line ack `WAKEUP_OK` is the plugin's ack-receipt token; the
+        // agent MUST then continue in the same session and drive the
+        // `hf-wakeup` workflow to completion (calendar_status → task fetch →
+        // sub-workflow → calendar_complete/abort). Without that continuation
+        // the scheduler keeps re-waking every 30s because the slot stays
+        // `not_started` forever.
         const wakeupMessage =
-          `You have due slots. Drive the \`hf-wakeup\` workflow of skill ` +
-          `\`hf-hangman-lab\` to completion in this session — read slot ` +
-          `context, call the harborforge_calendar_* tools, route to the ` +
-          `right sub-workflow, and finish with harborforge_calendar_complete ` +
-          `or harborforge_calendar_abort. The scheduler keeps re-waking you ` +
-          `every 30s until the slot transitions out of \`not_started\`, so ` +
-          `partial work or silence just produces another wake.${slotBlock}`;
+          `You have due slots. **First line of your reply MUST be exactly ` +
+          `\`WAKEUP_OK\`** so the plugin records the ack. Then, **in this ` +
+          `same session**, drive the \`hf-wakeup\` workflow of skill ` +
+          `\`hf-hangman-lab\` to completion — read slot context, call the ` +
+          `harborforge_calendar_* tools, route to the right sub-workflow, ` +
+          `and finish with harborforge_calendar_complete or abort. Do NOT ` +
+          `stop after the ack — the scheduler will re-wake you every 30s ` +
+          `until the slot transitions out of \`not_started\`.${slotBlock}`;
 
         const result = await dispatchInboundMessageWithDispatcher({
           ctx: {
@@ -397,94 +356,6 @@ function register(api: PluginAPI): void {
         }
       }
 
-      // Cross-plugin exposure: agent status lookup for other plugins
-      // (currently Fabric.OpenclawPlugin uses this to skip delivering
-      // `announce` channel messages to busy agents — see DIALECTIC-V2
-      // design doc, Phase 1). Backed by calendarBridge.getAgentStatus
-      // with a small TTL cache to avoid hammering the HF backend.
-      type HfStatus = 'idle' | 'on_call' | 'busy' | 'exhausted' | 'offline';
-      const HF_STATUS_CACHE_TTL_MS = 30_000;
-      const hfStatusCache = new Map<string, { status: HfStatus; at: number }>();
-      const _G = globalThis as Record<string, unknown>;
-      _G['__hfAgentStatus'] = {
-        async get(agentId: string): Promise<HfStatus | undefined> {
-          if (!agentId) return undefined;
-          const cached = hfStatusCache.get(agentId);
-          if (cached && Date.now() - cached.at < HF_STATUS_CACHE_TTL_MS) {
-            return cached.status;
-          }
-          try {
-            const status = await calendarBridge.getAgentStatus(agentId);
-            if (status) {
-              const typed = status as HfStatus;
-              hfStatusCache.set(agentId, { status: typed, at: Date.now() });
-              return typed;
-            }
-          } catch {
-            /* fall through to cached-or-undefined */
-          }
-          return cached?.status;
-        },
-
-        /**
-         * Approximate "does agent have an on_call slot covering [from, to]?"
-         * for cross-plugin pre-check use (currently:
-         * Dialectic.OpenclawPlugin's signup HF coverage).
-         *
-         * v1 honest scope: we only have today's slots in scheduleCache
-         * (synced from /calendar/sync which is today-only). Returns:
-         *   - true  iff window is same-day AND some cached on_call slot
-         *           starts <= from AND ends >= to
-         *   - false iff window is same-day AND no such slot
-         *   - undefined for cross-day windows OR cache empty for this
-         *     agent (caller treats undefined as "I don't know" — see
-         *     Dialectic plugin's hf-precheck.ts which degrades to
-         *     "skipped" gracefully)
-         *
-         * Phase TBD: when HF backend ships a `/calendar/slots?agent&from&to`
-         * endpoint, swap this to call it for arbitrary windows. Until then,
-         * same-day-only coverage gates ~all debates created by analyze-intel
-         * (which schedules <2h windows) without needing a backend change.
-         */
-        async hasOnCallCovering(
-          agentId: string,
-          fromIso: string,
-          toIso: string,
-        ): Promise<boolean | undefined> {
-          if (!agentId || !fromIso || !toIso) return undefined;
-          const from = new Date(fromIso);
-          const to = new Date(toIso);
-          if (isNaN(from.getTime()) || isNaN(to.getTime())) return undefined;
-          if (!(from < to)) return undefined;
-          // Cross-day → cache only has today; can't decide.
-          const fromDate = from.toISOString().slice(0, 10);
-          const toDate = to.toISOString().slice(0, 10);
-          if (fromDate !== toDate) return undefined;
-          // Cache's cachedDate must match our window's date.
-          const cacheStatus = scheduleCache.getStatus();
-          if (cacheStatus.cachedDate !== fromDate) return undefined;
-          const slots = scheduleCache.getAgentSlots(agentId);
-          if (slots.length === 0) return undefined; // cache empty for this agent — can't decide
-          for (const s of slots) {
-            if (s.slot_type !== 'on_call') continue;
-            // status: ignore aborted/cancelled, accept not_started / ongoing / finished
-            if (s.status === 'aborted' || s.status === 'cancelled') continue;
-            const startStr = s.scheduled_at;
-            if (typeof startStr !== 'string') continue;
-            // scheduled_at can be HH:MM:SS (cache-relative date) or full ISO
-            const start =
-              /^\d{2}:\d{2}(:\d{2})?$/.test(startStr)
-                ? new Date(`${fromDate}T${startStr}Z`)
-                : new Date(startStr);
-            if (isNaN(start.getTime())) continue;
-            const dur = typeof s.estimated_duration === 'number' ? s.estimated_duration : 0;
-            const end = new Date(start.getTime() + dur * 60_000);
-            if (start <= from && end >= to) return true;
-          }
-          return false;
-        },
-      };
-
       // Track wakes already dispatched for a slot in the current sync
       // window — the simplified inline scheduler does not PATCH slot
       // status server-side, so without dedupe the check loop re-wakes