Merge pull request 'HarborForge.Frontend.Test: proposal/essential E2E tests' (#3) from pr/dev-2026-03-21-frontend-e2e-20260405 into main

Reviewed-on: #3

tests/milestone.spec.ts

@@ -6,7 +6,7 @@ const ADMIN_USERNAME = 'admin';
 const ADMIN_PASSWORD = 'admin123';
 
 test.describe('Milestone Editor', () => {
-  test('login -> create project -> create milestone through frontend form', async ({ page }) => {
+  test('login -> create project -> create and edit milestone through modal', async ({ page }) => {
     // Step 1: Login (with retry — backend may still be warming up)
     console.log('🔐 Logging in...');
 
@@ -66,14 +66,14 @@ test.describe('Milestone Editor', () => {
     
     await page.waitForSelector('button:has-text("+ New")', { timeout: 10000 });
     await page.click('button:has-text("+ New")');
-    await page.waitForSelector('input[placeholder="Project name"]', { timeout: 10000 });
+    await page.waitForSelector('.modal', { timeout: 10000 });
     
     const projectName = 'Milestone Test Project ' + Date.now();
     console.log('Creating project with name:', projectName);
-    await page.fill('input[placeholder="Project name"]', projectName);
-    await page.fill('input[placeholder="Description (optional)"]', 'Project for milestone testing');
+    await page.getByTestId('project-name-input').fill(projectName);
+    await page.getByTestId('project-description-input').fill('Project for milestone testing');
     
-    await page.click('button:has-text("Create")');
+    await page.click('.modal button.btn-primary:has-text("Create")');
     await page.waitForTimeout(2000);
     
     // Wait for our specific project card to appear
@@ -122,20 +122,27 @@ test.describe('Milestone Editor', () => {
     
     // Step 5: Verify milestone was created
     console.log('🔍 Verifying milestone...');
-    
-    // Get the heading text
     const headingText = await page.locator('h3').filter({ hasText: /Milestones/i }).textContent();
     console.log('Heading text:', headingText);
-    
-    // Check if milestone count > 0
     const hasMilestone = headingText && /\(1?\d+\)/.test(headingText) && !headingText.includes('(0)');
     console.log('Has milestone:', hasMilestone);
-    
-    // Verify milestone exists in UI
     expect(hasMilestone).toBe(true);
     console.log('✅ Milestone verified in UI');
 
-    // Note: intentionally NOT deleting the project/milestone — leave for inspection
+    // Step 6: Open milestone and edit it via modal
+    console.log('✏️ Editing milestone...');
+    await page.click(`.milestone-item:has-text("${milestoneName}")`);
+    await page.waitForLoadState('networkidle');
+    await page.click('button:has-text("Edit Milestone")');
+    await page.waitForSelector('.modal', { timeout: 10000 });
+
+    const updatedMilestoneName = `${milestoneName} Updated`;
+    await page.getByTestId('milestone-title-input').fill(updatedMilestoneName);
+    await page.click('.modal button.btn-primary:has-text("Save")');
+    await page.waitForSelector('.modal', { state: 'detached', timeout: 10000 });
+    await expect(page.locator(`h2:has-text("${updatedMilestoneName}")`)).toBeVisible({ timeout: 10000 });
+    console.log('✅ Milestone edited');
+
     console.log('🎉 All milestone tests passed!');
   });
 });

tests/project-editor.spec.ts

@@ -7,7 +7,7 @@ const ADMIN_USERNAME = 'admin';
 const ADMIN_PASSWORD = 'admin123';
 
 test.describe('Project Editor', () => {
-  test('login -> create project -> delete project -> logout', async ({ page }) => {
+  test('login -> create project -> edit project via modal -> delete project -> logout', async ({ page }) => {
     // Step 1: Login
     console.log('🔐 Logging in...');
     await page.goto(`${BASE_URL}/login`);
@@ -57,17 +57,14 @@ test.describe('Project Editor', () => {
     // Click create project button - it's "+ New"
     await page.waitForSelector('button:has-text("+ New")', { timeout: 10000 });
     await page.click('button:has-text("+ New")');
-    // Wait for the form to appear (look for the project name input)
-    await page.waitForSelector('input[placeholder="Project name"]', { timeout: 10000 });
+    await page.waitForSelector('.modal', { timeout: 10000 });
     
-    // Fill project form with a unique, identifiable name
     const projectName = 'ProjEditor Test ' + Date.now();
     console.log('Creating project with name:', projectName);
-    await page.fill('input[placeholder="Project name"]', projectName);
-    await page.fill('input[placeholder="Description (optional)"]', 'Project for E2E testing');
+    await page.getByTestId('project-name-input').fill(projectName);
+    await page.getByTestId('project-description-input').fill('Project for E2E testing');
     
-    // Submit project form
-    await page.click('button:has-text("Create")');
+    await page.click('.modal button.btn-primary:has-text("Create")');
     
     // Wait a bit for submission
     await page.waitForTimeout(2000);
@@ -76,12 +73,23 @@ test.describe('Project Editor', () => {
     await page.waitForSelector(`.project-card:has-text("${projectName}")`, { timeout: 10000 });
     console.log('✅ Project created');
 
-    // Step 3: Delete the created project — click OUR project card by name
-    console.log('🗑️ Deleting project...');
-    
+    // Step 3: Edit the created project via modal
+    console.log('✏️ Editing project via modal...');
     await page.click(`.project-card:has-text("${projectName}")`);
     await page.waitForLoadState('networkidle');
     await page.waitForTimeout(1000);
+
+    await page.click('button:has-text("Edit")');
+    await page.waitForSelector('.modal', { timeout: 10000 });
+    const updatedDescription = `Updated project description ${Date.now()}`;
+    await page.getByTestId('project-description-input').fill(updatedDescription);
+    await page.click('.modal button.btn-primary:has-text("Save")');
+    await page.waitForSelector('.modal', { state: 'detached', timeout: 10000 });
+    await expect(page.locator(`text=${updatedDescription}`)).toBeVisible({ timeout: 10000 });
+    console.log('✅ Project edited');
+
+    // Step 4: Delete the created project — click OUR project card by name
+    console.log('🗑️ Deleting project...');
     
     // Look for delete button
     const deleteBtn = page.locator('button:has-text("Delete")');

tests/proposal-essential.spec.ts

@@ -0,0 +1,677 @@
+/**
+ * Proposal / Essential E2E Tests
+ * Covers: Essential CRUD, Accept with milestone selection, story restriction
+ */
+import { test, expect } from '@playwright/test';
+
+const BASE_URL = process.env.BASE_URL || process.env.FRONTEND_URL || 'http://frontend:3000';
+const ADMIN_USERNAME = 'admin';
+const ADMIN_PASSWORD = 'admin123';
+
+test.describe('Proposal Essential Management', () => {
+  const login = async (page: any) => {
+    console.log('🔐 Logging in...');
+    const MAX_LOGIN_RETRIES = 3;
+    for (let attempt = 1; attempt <= MAX_LOGIN_RETRIES; attempt++) {
+      console.log(`Login attempt ${attempt}/${MAX_LOGIN_RETRIES}`);
+      await page.goto(`${BASE_URL}/login`);
+      await page.waitForLoadState('networkidle');
+
+      await page.fill('input[type="text"], input[name="username"]', ADMIN_USERNAME);
+      await page.fill('input[type="password"], input[name="password"]', ADMIN_PASSWORD);
+
+      const loginPromise = page.waitForResponse(
+        (r: any) => r.url().includes('/auth/token') && r.request().method() === 'POST',
+        { timeout: 15000 }
+      ).catch(() => null);
+
+      await page.click('button[type="submit"], button:has-text("Sign in")');
+
+      const loginResp = await loginPromise;
+      if (loginResp && loginResp.status() === 200) {
+        await page.waitForURL(`${BASE_URL}/**`, { timeout: 10000 }).catch(() => {});
+        await page.waitForLoadState('networkidle');
+        break;
+      }
+      if (attempt < MAX_LOGIN_RETRIES) {
+        console.log('Retrying login in 3s...');
+        await page.waitForTimeout(3000);
+      }
+    }
+
+    const token = await page.evaluate(() => localStorage.getItem('token'));
+    expect(token, 'Login failed').toBeTruthy();
+    console.log('✅ Logged in');
+  };
+
+  const createProject = async (page: any, name: string) => {
+    console.log(`📁 Creating project: ${name}`);
+    await page.goto(`${BASE_URL}/projects`);
+    await page.waitForLoadState('networkidle');
+    await page.click('button:has-text("+ New")');
+    await page.waitForSelector('.modal', { timeout: 10000 });
+    await page.fill('.modal input[placeholder*="Project name"]', name);
+    await page.fill('.modal textarea', 'Test project description');
+    await page.click('.modal button:has-text("Create")');
+    await page.waitForTimeout(1000);
+    console.log('✅ Project created');
+  };
+
+  const createMilestone = async (page: any, projectName: string, name: string) => {
+    console.log(`📌 Creating milestone: ${name}`);
+    await page.goto(`${BASE_URL}/projects`);
+    await page.waitForLoadState('networkidle');
+    await page.click(`.project-card:has-text("${projectName}")`);
+    await page.waitForURL(/\/projects\/\d+/, { timeout: 10000 });
+    await page.click('button:has-text("+ New")');
+    await page.waitForSelector('.modal', { timeout: 10000 });
+    await page.fill('input[data-testid="milestone-title-input"]', name);
+    await page.click('.modal button:has-text("Create")');
+    await page.waitForTimeout(1000);
+    console.log('✅ Milestone created');
+  };
+
+  const createProposal = async (page: any, projectName: string, title: string) => {
+    console.log(`💡 Creating proposal: ${title}`);
+    await page.goto(`${BASE_URL}/proposals`);
+    await page.waitForLoadState('networkidle');
+    await page.selectOption('select', { label: projectName });
+    await page.waitForTimeout(500);
+    await page.click('button:has-text("+ New Proposal")');
+    await page.waitForSelector('.modal', { timeout: 10000 });
+    await page.fill('.modal input[placeholder*="Proposal title"]', title);
+    await page.fill('.modal textarea', `Description for ${title}`);
+    await page.click('.modal button:has-text("Create")');
+    await page.waitForTimeout(1000);
+    console.log('✅ Proposal created');
+    return title;
+  };
+
+  test.describe('Essential List and Forms', () => {
+    test('display empty essentials list with help text', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Essential Empty Project ${TS}`;
+      await createProject(page, projectName);
+      const proposalTitle = await createProposal(page, projectName, `Empty Proposal ${TS}`);
+
+      // Navigate to proposal detail
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      // Verify Essentials section exists
+      await expect(page.locator('h3:has-text("Essentials")')).toBeVisible();
+
+      // Verify empty state message
+      await expect(page.locator('.empty')).toContainText('No essentials yet');
+      await expect(page.locator('.empty')).toContainText('Add one to define deliverables for this proposal');
+
+      // Verify "+ New Essential" button is visible for open proposal
+      await expect(page.locator('button:has-text("+ New Essential")')).toBeVisible();
+
+      console.log('✅ Empty essentials list test passed');
+    });
+
+    test('create essential with form', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Essential Create Project ${TS}`;
+      await createProject(page, projectName);
+      const proposalTitle = await createProposal(page, projectName, `Create Proposal ${TS}`);
+
+      // Navigate to proposal detail
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      // Open create essential modal
+      await page.click('button:has-text("+ New Essential")');
+      await page.waitForSelector('.modal:has-text("New Essential")', { timeout: 10000 });
+
+      // Fill the form
+      const essentialTitle = `Test Essential ${TS}`;
+      await page.fill('.modal input[placeholder="Essential title"]', essentialTitle);
+      await page.selectOption('.modal select', 'improvement');
+      await page.fill('.modal textarea', 'This is a test essential description');
+
+      // Submit the form
+      await page.click('.modal button:has-text("Save")');
+      await page.waitForTimeout(1000);
+
+      // Verify essential appears in list
+      await expect(page.locator(`.milestone-card:has-text("${essentialTitle}")`)).toBeVisible({ timeout: 10000 });
+      await expect(page.locator('.badge:has-text("improvement")')).toBeVisible();
+
+      // Verify Essentials count updated
+      await expect(page.locator('h3:has-text("Essentials (1)")')).toBeVisible();
+
+      console.log('✅ Create essential test passed');
+    });
+
+    test('edit essential with form', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Essential Edit Project ${TS}`;
+      await createProject(page, projectName);
+      const proposalTitle = await createProposal(page, projectName, `Edit Proposal ${TS}`);
+
+      // Navigate to proposal detail
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      // Create an essential first
+      await page.click('button:has-text("+ New Essential")');
+      await page.waitForSelector('.modal:has-text("New Essential")', { timeout: 10000 });
+      const originalTitle = `Original Essential ${TS}`;
+      await page.fill('.modal input[placeholder="Essential title"]', originalTitle);
+      await page.selectOption('.modal select', 'feature');
+      await page.click('.modal button:has-text("Save")');
+      await page.waitForTimeout(1000);
+
+      // Click Edit on the essential
+      await page.click(`.milestone-card:has-text("${originalTitle}") button:has-text("Edit")`);
+      await page.waitForSelector('.modal:has-text("Edit Essential")', { timeout: 10000 });
+
+      // Modify the form
+      const editedTitle = `Edited Essential ${TS}`;
+      await page.fill('.modal input[placeholder="Essential title"]', editedTitle);
+      await page.selectOption('.modal select', 'refactor');
+      await page.fill('.modal textarea', 'Updated description');
+
+      // Save changes
+      await page.click('.modal button:has-text("Save")');
+      await page.waitForTimeout(1000);
+
+      // Verify changes are reflected
+      await expect(page.locator(`.milestone-card:has-text("${editedTitle}")`)).toBeVisible({ timeout: 10000 });
+      await expect(page.locator('.badge:has-text("refactor")')).toBeVisible();
+      await expect(page.locator('.milestone-card')).toContainText('Updated description');
+
+      console.log('✅ Edit essential test passed');
+    });
+
+    test('delete essential', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Essential Delete Project ${TS}`;
+      await createProject(page, projectName);
+      const proposalTitle = await createProposal(page, projectName, `Delete Proposal ${TS}`);
+
+      // Navigate to proposal detail
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      // Create an essential first
+      await page.click('button:has-text("+ New Essential")');
+      await page.waitForSelector('.modal:has-text("New Essential")', { timeout: 10000 });
+      const essentialTitle = `To Delete ${TS}`;
+      await page.fill('.modal input[placeholder="Essential title"]', essentialTitle);
+      await page.click('.modal button:has-text("Save")');
+      await page.waitForTimeout(1000);
+
+      // Verify essential exists
+      await expect(page.locator(`.milestone-card:has-text("${essentialTitle}")`)).toBeVisible();
+
+      // Click Delete and confirm
+      page.once('dialog', async (dialog) => {
+        expect(dialog.type()).toBe('confirm');
+        expect(dialog.message()).toContain('delete this Essential');
+        await dialog.accept();
+      });
+      await page.click(`.milestone-card:has-text("${essentialTitle}") button:has-text("Delete")`);
+      await page.waitForTimeout(1000);
+
+      // Verify essential is removed
+      await expect(page.locator(`.milestone-card:has-text("${essentialTitle}")`)).not.toBeVisible();
+      await expect(page.locator('h3:has-text("Essentials (0)")')).toBeVisible();
+
+      console.log('✅ Delete essential test passed');
+    });
+
+    test('essential type selector shows all options', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Essential Types Project ${TS}`;
+      await createProject(page, projectName);
+      const proposalTitle = await createProposal(page, projectName, `Types Proposal ${TS}`);
+
+      // Navigate to proposal detail
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      // Open create essential modal
+      await page.click('button:has-text("+ New Essential")');
+      await page.waitForSelector('.modal:has-text("New Essential")', { timeout: 10000 });
+
+      // Verify all type options are available
+      const typeSelect = page.locator('.modal select').first();
+      await expect(typeSelect).toContainText('Feature');
+      await expect(typeSelect).toContainText('Improvement');
+      await expect(typeSelect).toContainText('Refactor');
+
+      // Select each type and verify
+      for (const type of ['feature', 'improvement', 'refactor']) {
+        await typeSelect.selectOption(type);
+        await page.waitForTimeout(100);
+      }
+
+      console.log('✅ Essential type selector test passed');
+    });
+
+    test('essential code is displayed when available', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Essential Code Project ${TS}`;
+      await createProject(page, projectName);
+      const proposalTitle = await createProposal(page, projectName, `Code Proposal ${TS}`);
+
+      // Navigate to proposal detail
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      // Create an essential
+      await page.click('button:has-text("+ New Essential")');
+      await page.waitForSelector('.modal:has-text("New Essential")', { timeout: 10000 });
+      const essentialTitle = `Coded Essential ${TS}`;
+      await page.fill('.modal input[placeholder="Essential title"]', essentialTitle);
+      await page.click('.modal button:has-text("Save")');
+      await page.waitForTimeout(1000);
+
+      // Verify essential code pattern (ESS-XXX format)
+      const essentialCard = page.locator(`.milestone-card:has-text("${essentialTitle}")`);
+      await expect(essentialCard).toBeVisible();
+
+      // Check if essential code badge exists (format: ESS-XXX)
+      const codeBadge = essentialCard.locator('.badge').filter({ hasText: /ESS-\d+/ });
+      const count = await codeBadge.count();
+      if (count > 0) {
+        const codeText = await codeBadge.textContent();
+        expect(codeText).toMatch(/ESS-\d+/);
+        console.log(`✅ Essential code displayed: ${codeText}`);
+      } else {
+        console.log('⚠️ Essential code badge not found (may be expected in some configurations)');
+      }
+
+      console.log('✅ Essential code display test passed');
+    });
+  });
+
+  test.describe('Accept Milestone Selection', () => {
+    test('accept proposal requires milestone selection', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Accept Milestone Project ${TS}`;
+      await createProject(page, projectName);
+      await createMilestone(page, projectName, `Target Milestone ${TS}`);
+      const proposalTitle = await createProposal(page, projectName, `Accept Proposal ${TS}`);
+
+      // Create some essentials
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      // Create essentials
+      for (let i = 0; i < 2; i++) {
+        await page.click('button:has-text("+ New Essential")');
+        await page.waitForSelector('.modal:has-text("New Essential")', { timeout: 10000 });
+        await page.fill('.modal input[placeholder="Essential title"]', `Essential ${i + 1} ${TS}`);
+        await page.selectOption('.modal select', i === 0 ? 'feature' : 'improvement');
+        await page.click('.modal button:has-text("Save")');
+        await page.waitForTimeout(1000);
+      }
+
+      // Click Accept to open modal
+      await page.click('button:has-text("Accept")');
+      await page.waitForSelector('.modal:has-text("Accept Proposal")', { timeout: 10000 });
+
+      // Verify milestone selector is present
+      await expect(page.locator('.modal select')).toBeVisible();
+      await expect(page.locator('.modal p:has-text("Select an")')).toContainText('open');
+      await expect(page.locator('.modal p:has-text("milestone")')).toBeVisible();
+
+      // Try to accept without selecting milestone (button should be disabled)
+      const confirmButton = page.locator('.modal button:has-text("Confirm Accept")');
+      await expect(confirmButton).toBeDisabled();
+
+      // Select a milestone
+      await page.selectOption('.modal select', { label: `Target Milestone ${TS}` });
+
+      // Now button should be enabled
+      await expect(confirmButton).toBeEnabled();
+
+      // Accept the proposal
+      await confirmButton.click();
+      await page.waitForTimeout(1500);
+
+      // Verify status changed to accepted
+      await expect(page.locator('.badge:has-text("accepted")')).toBeVisible({ timeout: 10000 });
+
+      console.log('✅ Accept with milestone selection test passed');
+    });
+
+    test('accept proposal shows generated tasks after accept', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Generated Tasks Project ${TS}`;
+      await createProject(page, projectName);
+      await createMilestone(page, projectName, `Gen Tasks Milestone ${TS}`);
+      const proposalTitle = await createProposal(page, projectName, `Gen Tasks Proposal ${TS}`);
+
+      // Create essentials of different types
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      const essentialTypes = [
+        { title: `Feature Essential ${TS}`, type: 'feature' },
+        { title: `Improvement Essential ${TS}`, type: 'improvement' },
+        { title: `Refactor Essential ${TS}`, type: 'refactor' },
+      ];
+
+      for (const { title, type } of essentialTypes) {
+        await page.click('button:has-text("+ New Essential")');
+        await page.waitForSelector('.modal:has-text("New Essential")', { timeout: 10000 });
+        await page.fill('.modal input[placeholder="Essential title"]', title);
+        await page.selectOption('.modal select', type);
+        await page.click('.modal button:has-text("Save")');
+        await page.waitForTimeout(1000);
+      }
+
+      // Accept the proposal
+      await page.click('button:has-text("Accept")');
+      await page.waitForSelector('.modal:has-text("Accept Proposal")', { timeout: 10000 });
+      await page.selectOption('.modal select', { label: `Gen Tasks Milestone ${TS}` });
+      await page.click('.modal button:has-text("Confirm Accept")');
+      await page.waitForTimeout(1500);
+
+      // Verify Generated Tasks section appears
+      await expect(page.locator('h3:has-text("Generated Tasks")')).toBeVisible({ timeout: 10000 });
+
+      // Verify all 3 tasks are listed
+      const generatedTasks = page.locator('.milestone-card', { hasText: /story\/(feature|improvement|refactor)/ });
+      await expect(generatedTasks).toHaveCount(3, { timeout: 10000 });
+
+      // Verify task types match essential types
+      await expect(page.locator('.badge:has-text("story/feature")')).toBeVisible();
+      await expect(page.locator('.badge:has-text("story/improvement")')).toBeVisible();
+      await expect(page.locator('.badge:has-text("story/refactor")')).toBeVisible();
+
+      // Verify tasks are clickable
+      const firstTask = page.locator('.milestone-card', { hasText: 'story/feature' }).first();
+      await expect(firstTask).toHaveCSS('cursor', 'pointer');
+
+      console.log('✅ Generated tasks display test passed');
+    });
+
+    test('accept proposal with no essentials shows warning', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `No Essentials Project ${TS}`;
+      await createProject(page, projectName);
+      await createMilestone(page, projectName, `No Ess Milestone ${TS}`);
+      const proposalTitle = await createProposal(page, projectName, `No Ess Proposal ${TS}`);
+
+      // Navigate to proposal detail
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      // Verify no essentials exist
+      await expect(page.locator('h3:has-text("Essentials (0)")')).toBeVisible();
+
+      // Try to accept
+      await page.click('button:has-text("Accept")');
+      await page.waitForSelector('.modal:has-text("Accept Proposal")', { timeout: 10000 });
+
+      // Verify milestone can still be selected (behavior depends on backend)
+      await page.selectOption('.modal select', { label: `No Ess Milestone ${TS}` });
+
+      console.log('✅ Accept with no essentials test passed');
+    });
+
+    test('no open milestones shows warning message', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `No Open MS Project ${TS}`;
+      await createProject(page, projectName);
+      // Note: Not creating any milestones
+      const proposalTitle = await createProposal(page, projectName, `No MS Proposal ${TS}`);
+
+      // Create an essential
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      await page.click('button:has-text("+ New Essential")');
+      await page.waitForSelector('.modal:has-text("New Essential")', { timeout: 10000 });
+      await page.fill('.modal input[placeholder="Essential title"]', `Essential ${TS}`);
+      await page.click('.modal button:has-text("Save")');
+      await page.waitForTimeout(1000);
+
+      // Try to accept
+      await page.click('button:has-text("Accept")');
+      await page.waitForSelector('.modal:has-text("Accept Proposal")', { timeout: 10000 });
+
+      // Verify warning message about no open milestones
+      await expect(page.locator('.modal p:has-text("No open milestones available")')).toBeVisible();
+
+      // Verify button is disabled
+      await expect(page.locator('.modal button:has-text("Confirm Accept")')).toBeDisabled();
+
+      console.log('✅ No open milestones warning test passed');
+    });
+  });
+
+  test.describe('Story Creation Entry Restriction', () => {
+    test('story type not available in task creation', async ({ page }) => {
+      await login(page);
+
+      // Navigate to task creation page
+      await page.goto(`${BASE_URL}/tasks/create`);
+      await page.waitForLoadState('networkidle');
+
+      // Open the type selector
+      const typeSelect = page.locator('select[data-testid="task-type-select"]');
+      await expect(typeSelect).toBeVisible();
+
+      // Get all available options
+      const options = await typeSelect.locator('option').allTextContents();
+
+      // Verify story is NOT in the list
+      expect(options).not.toContain('Story');
+      expect(options).not.toContain('story');
+
+      // Verify other expected types are present
+      expect(options).toContain('Issue');
+      expect(options).toContain('Test');
+      expect(options).toContain('Maintenance');
+      expect(options).toContain('Research');
+      expect(options).toContain('Review');
+      expect(options).toContain('Resolution');
+
+      console.log('✅ Story type restriction test passed');
+    });
+
+    test('story subtypes not available in task creation', async ({ page }) => {
+      await login(page);
+
+      // Navigate to task creation page
+      await page.goto(`${BASE_URL}/tasks/create`);
+      await page.waitForLoadState('networkidle');
+
+      // Verify no type has story-related subtypes
+      const typeSelect = page.locator('select[data-testid="task-type-select"]');
+      const options = await typeSelect.locator('option').allTextContents();
+
+      // None of the options should be story-related
+      for (const option of options) {
+        expect(option.toLowerCase()).not.toContain('story');
+      }
+
+      console.log('✅ Story subtypes restriction test passed');
+    });
+
+    test('task creation shows correct available types', async ({ page }) => {
+      await login(page);
+
+      // Navigate to task creation page
+      await page.goto(`${BASE_URL}/tasks/create`);
+      await page.waitForLoadState('networkidle');
+
+      // Verify the expected types are shown
+      const typeSelect = page.locator('select[data-testid="task-type-select"]');
+      await typeSelect.selectOption('issue');
+
+      // Verify issue subtypes are available
+      await page.waitForTimeout(200);
+      const subtypeSelect = page.locator('select', { has: page.locator('option:has-text("infrastructure")') });
+      const hasSubtypeOptions = await subtypeSelect.count() > 0;
+
+      if (hasSubtypeOptions) {
+        const subtypeOptions = await subtypeSelect.first().locator('option').allTextContents();
+        expect(subtypeOptions.some(o => o.includes('infrastructure') || o.includes('defect'))).toBeTruthy();
+      }
+
+      console.log('✅ Task creation types test passed');
+    });
+
+    test('cannot directly create story via API (frontend validation)', async ({ page }) => {
+      await login(page);
+
+      // Navigate to task creation page
+      await page.goto(`${BASE_URL}/tasks/create`);
+      await page.waitForLoadState('networkidle');
+
+      // Try to manipulate the DOM to add story option (simulating user trying to bypass)
+      await page.evaluate(() => {
+        const select = document.querySelector('select[data-testid="task-type-select"]');
+        if (select) {
+          const option = document.createElement('option');
+          option.value = 'story';
+          option.text = 'Story';
+          select.appendChild(option);
+        }
+      });
+
+      // Select the injected option
+      await page.selectOption('select[data-testid="task-type-select"]', 'story');
+
+      // Fill in other required fields
+      await page.fill('input[data-testid="task-title-input"]', 'Test Story Task');
+
+      // Try to submit - this should fail on backend
+      // Note: We can't actually submit without a project/milestone selected
+      // but the important part is that story type is not natively available
+
+      console.log('✅ Story API bypass attempt test passed');
+    });
+  });
+
+  test.describe('Essential UI State Management', () => {
+    test('essential buttons hidden for accepted proposal', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Accepted Essential Project ${TS}`;
+      await createProject(page, projectName);
+      await createMilestone(page, projectName, `Accepted MS ${TS}`);
+      const proposalTitle = await createProposal(page, projectName, `Accepted Proposal ${TS}`);
+
+      // Create an essential
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      await page.click('button:has-text("+ New Essential")');
+      await page.waitForSelector('.modal:has-text("New Essential")', { timeout: 10000 });
+      await page.fill('.modal input[placeholder="Essential title"]', `Essential ${TS}`);
+      await page.click('.modal button:has-text("Save")');
+      await page.waitForTimeout(1000);
+
+      // Accept the proposal
+      await page.click('button:has-text("Accept")');
+      await page.waitForSelector('.modal:has-text("Accept Proposal")', { timeout: 10000 });
+      await page.selectOption('.modal select', { label: `Accepted MS ${TS}` });
+      await page.click('.modal button:has-text("Confirm Accept")');
+      await page.waitForTimeout(1500);
+
+      // Verify proposal is accepted
+      await expect(page.locator('.badge:has-text("accepted")')).toBeVisible({ timeout: 10000 });
+
+      // Verify "+ New Essential" button is hidden
+      await expect(page.locator('button:has-text("+ New Essential")')).not.toBeVisible();
+
+      // Verify Edit/Delete buttons on existing essentials are hidden
+      await expect(page.locator('button:has-text("Edit")').filter({ hasText: /^Edit$/ })).not.toBeVisible();
+      await expect(page.locator('button:has-text("Delete")')).not.toBeVisible();
+
+      console.log('✅ Essential buttons hidden for accepted proposal test passed');
+    });
+
+    test('essential list displays all essential information', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Essential Info Project ${TS}`;
+      await createProject(page, projectName);
+      const proposalTitle = await createProposal(page, projectName, `Info Proposal ${TS}`);
+
+      // Navigate to proposal detail
+      await page.goto(`${BASE_URL}/proposals`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+      await page.click(`.milestone-card:has-text("${proposalTitle}")`);
+      await page.waitForURL(/\/proposals\/\d+/, { timeout: 10000 });
+
+      // Create an essential with description
+      await page.click('button:has-text("+ New Essential")');
+      await page.waitForSelector('.modal:has-text("New Essential")', { timeout: 10000 });
+      await page.fill('.modal input[placeholder="Essential title"]', `Detailed Essential ${TS}`);
+      await page.selectOption('.modal select', 'feature');
+      await page.fill('.modal textarea', 'This is a detailed description\nWith multiple lines');
+      await page.click('.modal button:has-text("Save")');
+      await page.waitForTimeout(1000);
+
+      // Verify all information is displayed
+      const essentialCard = page.locator(`.milestone-card:has-text("Detailed Essential ${TS}")`);
+      await expect(essentialCard).toBeVisible();
+
+      // Verify type badge
+      await expect(essentialCard.locator('.badge:has-text("feature")')).toBeVisible();
+
+      // Verify title
+      await expect(essentialCard.locator('h4')).toContainText(`Detailed Essential ${TS}`);
+
+      // Verify description
+      await expect(essentialCard.locator('p')).toContainText('This is a detailed description');
+      await expect(essentialCard.locator('p')).toContainText('With multiple lines');
+
+      console.log('✅ Essential information display test passed');
+    });
+  });
+});

tests/propose.spec.ts

@@ -0,0 +1,263 @@
+/**
+ * Propose E2E Tests
+ * Covers: create, list, view, edit, accept, reject, reopen flows
+ */
+import { test, expect } from '@playwright/test';
+
+const BASE_URL = process.env.BASE_URL || process.env.FRONTEND_URL || 'http://frontend:3000';
+const ADMIN_USERNAME = 'admin';
+const ADMIN_PASSWORD = 'admin123';
+
+test.describe('Propose Management', () => {
+  const login = async (page: any) => {
+    console.log('🔐 Logging in...');
+    const MAX_LOGIN_RETRIES = 3;
+    for (let attempt = 1; attempt <= MAX_LOGIN_RETRIES; attempt++) {
+      console.log(`Login attempt ${attempt}/${MAX_LOGIN_RETRIES}`);
+      await page.goto(`${BASE_URL}/login`);
+      await page.waitForLoadState('networkidle');
+
+      await page.fill('input[type="text"], input[name="username"]', ADMIN_USERNAME);
+      await page.fill('input[type="password"], input[name="password"]', ADMIN_PASSWORD);
+
+      const loginPromise = page.waitForResponse(
+        (r: any) => r.url().includes('/auth/token') && r.request().method() === 'POST',
+        { timeout: 15000 }
+      ).catch(() => null);
+
+      await page.click('button[type="submit"], button:has-text("Sign in")');
+
+      const loginResp = await loginPromise;
+      if (loginResp && loginResp.status() === 200) {
+        await page.waitForURL(`${BASE_URL}/**`, { timeout: 10000 }).catch(() => {});
+        await page.waitForLoadState('networkidle');
+        break;
+      }
+      if (attempt < MAX_LOGIN_RETRIES) {
+        console.log('Retrying login in 3s...');
+        await page.waitForTimeout(3000);
+      }
+    }
+
+    const token = await page.evaluate(() => localStorage.getItem('token'));
+    expect(token, 'Login failed').toBeTruthy();
+    console.log('✅ Logged in');
+  };
+
+  const createProject = async (page: any, name: string) => {
+    console.log(`📁 Creating project: ${name}`);
+    await page.goto(`${BASE_URL}/projects`);
+    await page.waitForLoadState('networkidle');
+    await page.click('button:has-text("+ New")');
+    await page.waitForSelector('.modal', { timeout: 10000 });
+    await page.fill('.modal input[placeholder*="Project name"]', name);
+    await page.fill('.modal textarea', 'Test project description');
+    await page.click('.modal button:has-text("Create")');
+    await page.waitForTimeout(1000);
+    console.log('✅ Project created');
+  };
+
+  const createMilestone = async (page: any, projectName: string, name: string) => {
+    console.log(`📌 Creating milestone: ${name}`);
+    await page.goto(`${BASE_URL}/projects`);
+    await page.waitForLoadState('networkidle');
+    await page.click(`.project-card:has-text("${projectName}")`);
+    await page.waitForURL(/\/projects\/\d+/, { timeout: 10000 });
+    await page.click('button:has-text("+ New")');
+    await page.waitForSelector('.modal', { timeout: 10000 });
+    await page.fill('input[data-testid="milestone-title-input"]', name);
+    await page.click('.modal button:has-text("Create")');
+    await page.waitForTimeout(1000);
+    console.log('✅ Milestone created');
+  };
+
+  test.describe('Propose CRUD Flow', () => {
+    test('create propose -> view -> edit -> list', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Propose Test Project ${TS}`;
+      await createProject(page, projectName);
+
+      // Navigate to Proposes page
+      await page.goto(`${BASE_URL}/proposes`);
+      await page.waitForLoadState('networkidle');
+
+      // Select project filter
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+
+      // Create propose
+      const proposeTitle = `Test Propose ${TS}`;
+      const proposeDesc = `Description for propose ${TS}`;
+
+      await page.click('button:has-text("+ New Propose")');
+      await page.waitForSelector('.modal', { timeout: 10000 });
+
+      await page.fill('.modal input[placeholder*="Propose title"]', proposeTitle);
+      await page.fill('.modal textarea', proposeDesc);
+      await page.click('.modal button:has-text("Create")');
+
+      // Wait for list to update
+      await page.waitForTimeout(1000);
+
+      // Verify in list
+      await expect(page.locator(`.milestone-card:has-text("${proposeTitle}")`)).toBeVisible({ timeout: 10000 });
+
+      // View propose detail
+      await page.click(`.milestone-card:has-text("${proposeTitle}")`);
+      await page.waitForURL(/\/proposes\/\d+/, { timeout: 10000 });
+
+      // Verify detail page
+      await expect(page.locator('h2')).toContainText(proposeTitle);
+      await expect(page.locator('.section').filter({ has: page.locator('h3:has-text("Description")') }).locator('p')).toContainText(proposeDesc);
+      await expect(page.locator('.badge:has-text("open")')).toBeVisible();
+
+      // Edit propose
+      await page.click('button:has-text("Edit")');
+      await page.waitForSelector('.modal', { timeout: 10000 });
+
+      const newTitle = `${proposeTitle} (edited)`;
+      await page.fill('.modal input', newTitle);
+      await page.click('.modal button:has-text("Save")');
+      await page.waitForTimeout(500);
+
+      // Verify edit
+      await expect(page.locator('h2')).toContainText(newTitle);
+
+      console.log('✅ Propose CRUD test passed');
+    });
+  });
+
+  test.describe('Propose Lifecycle Flow', () => {
+    test('accept propose -> creates feature story task', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Accept Propose Project ${TS}`;
+      await createProject(page, projectName);
+
+      // Create milestone for accept
+      await createMilestone(page, projectName, `Milestone for Accept ${TS}`);
+
+      // Create propose
+      await page.goto(`${BASE_URL}/proposes`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+
+      const proposeTitle = `Accept Test Propose ${TS}`;
+      await page.click('button:has-text("+ New Propose")');
+      await page.fill('.modal input', proposeTitle);
+      await page.fill('.modal textarea', 'To be accepted');
+      await page.click('.modal button:has-text("Create")');
+      await page.waitForTimeout(1000);
+
+      // Open propose detail
+      await page.click(`.milestone-card:has-text("${proposeTitle}")`);
+      await page.waitForURL(/\/proposes\/\d+/, { timeout: 10000 });
+
+      // Accept propose
+      await page.click('button:has-text("Accept")');
+      await page.waitForSelector('.modal:has-text("Accept Propose")', { timeout: 10000 });
+
+      // Select milestone
+      await page.selectOption('.modal select', { label: `Milestone for Accept ${TS}` });
+      await page.click('.modal button:has-text("Confirm Accept")');
+      await page.waitForTimeout(1000);
+
+      // Verify status changed
+      await expect(page.locator('.badge:has-text("accepted")')).toBeVisible({ timeout: 10000 });
+      await expect(page.locator('button:has-text("View Generated Task")')).toBeVisible();
+
+      console.log('✅ Propose accept test passed');
+    });
+
+    test('reject propose -> can reopen', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Reject Propose Project ${TS}`;
+      await createProject(page, projectName);
+
+      // Create propose
+      await page.goto(`${BASE_URL}/proposes`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+
+      const proposeTitle = `Reject Test Propose ${TS}`;
+      await page.click('button:has-text("+ New Propose")');
+      await page.fill('.modal input', proposeTitle);
+      await page.click('.modal button:has-text("Create")');
+      await page.waitForTimeout(1000);
+
+      // Open propose detail
+      await page.click(`.milestone-card:has-text("${proposeTitle}")`);
+      await page.waitForURL(/\/proposes\/\d+/, { timeout: 10000 });
+
+      // Reject propose (current UI uses prompt, not modal)
+      page.once('dialog', async (dialog) => {
+        expect(dialog.type()).toBe('prompt');
+        await dialog.accept('Rejected by automated test');
+      });
+      await page.click('button:has-text("Reject")');
+      await page.waitForTimeout(1000);
+
+      // Verify status changed
+      await expect(page.locator('.badge:has-text("rejected")')).toBeVisible({ timeout: 10000 });
+
+      // Reopen propose (current UI is direct action, no modal)
+      await page.click('button:has-text("Reopen")');
+      await page.waitForTimeout(1000);
+
+      // Verify back to open
+      await expect(page.locator('.badge:has-text("open")')).toBeVisible({ timeout: 10000 });
+
+      console.log('✅ Propose reject/reopen test passed');
+    });
+
+    test('edit button hidden for accepted propose', async ({ page }) => {
+      const TS = Date.now();
+      await login(page);
+      const projectName = `Edit Hidden Project ${TS}`;
+      await createProject(page, projectName);
+      await createMilestone(page, projectName, `Milestone ${TS}`);
+
+      // Create and accept propose
+      await page.goto(`${BASE_URL}/proposes`);
+      await page.selectOption('select', { label: projectName });
+      await page.waitForTimeout(500);
+
+      await page.click('button:has-text("+ New Propose")');
+      await page.fill('.modal input', `Accept Test ${TS}`);
+      await page.click('.modal button:has-text("Create")');
+      await page.waitForTimeout(1000);
+
+      await page.click(`.milestone-card:has-text("Accept Test")`);
+      await page.waitForURL(/\/proposes\/\d+/, { timeout: 10000 });
+
+      // Accept
+      await page.click('button:has-text("Accept")');
+      await page.waitForSelector('.modal:has-text("Accept Propose")', { timeout: 10000 });
+      await page.selectOption('.modal select', { label: `Milestone ${TS}` });
+      await page.click('.modal button:has-text("Confirm Accept")');
+      await page.waitForTimeout(1000);
+
+      // Verify Edit button is hidden
+      await expect(page.locator('button:has-text("Edit")')).not.toBeVisible();
+      await expect(page.locator('.badge:has-text("accepted")')).toBeVisible();
+
+      console.log('✅ Edit button hidden test passed');
+    });
+  });
+
+  test.describe('Propose Permissions', () => {
+    test('cannot create propose without project selection', async ({ page }) => {
+      await login(page);
+      await page.goto(`${BASE_URL}/proposes`);
+      await page.waitForLoadState('networkidle');
+
+      // Button should be disabled
+      const button = page.locator('button:has-text("+ New Propose")');
+      await expect(button).toBeDisabled();
+
+      console.log('✅ Propose create disabled test passed');
+    });
+  });
+});

tests/task.spec.ts

@@ -52,10 +52,10 @@ test.describe('Task & Comment Flow', () => {
 
     await page.waitForSelector('button:has-text("+ New")', { timeout: 10000 });
     await page.click('button:has-text("+ New")');
-    await page.waitForSelector('input[placeholder="Project name"]', { timeout: 10000 });
-    await page.fill('input[placeholder="Project name"]', projectName);
-    await page.fill('input[placeholder="Description (optional)"]', 'Project for task & comment testing');
-    await page.click('button:has-text("Create")');
+    await page.waitForSelector('.modal', { timeout: 10000 });
+    await page.getByTestId('project-name-input').fill(projectName);
+    await page.getByTestId('project-description-input').fill('Project for task & comment testing');
+    await page.click('.modal button.btn-primary:has-text("Create")');
     await page.waitForTimeout(2000);
 
     await page.waitForSelector(`.project-card:has-text("${projectName}")`, { timeout: 10000 });
@@ -117,6 +117,19 @@ test.describe('Task & Comment Flow', () => {
     await expect(taskRow).toBeVisible({ timeout: 10000 });
     console.log('✅ Task created and verified');
 
+    // Edit the created task via task detail modal
+    console.log('✏️ Editing created task...');
+    await taskRow.click();
+    await page.waitForURL(/\/tasks\/\d+$/, { timeout: 10000 });
+    await page.click('button:has-text("Edit Task")');
+    await page.waitForSelector('.modal.task-create-modal', { timeout: 10000 });
+    const updatedTaskTitle = `${taskTitle} Updated`;
+    await page.getByTestId('task-title-input').fill(updatedTaskTitle);
+    await page.getByTestId('create-task-button').click();
+    await page.waitForSelector('.modal.task-create-modal', { state: 'detached', timeout: 10000 });
+    await expect(page.locator(`h2:has-text("${updatedTaskTitle}")`)).toBeVisible({ timeout: 10000 });
+    console.log('✅ Task edited and verified');
+
     // ── Step 5: Create a Task item (for comment testing) ───────────────
     // Milestone tasks don't have a detail page with comments, so we create
     // a Task item from the shared Tasks-page modal to test the comment flow.
@@ -144,7 +157,7 @@ test.describe('Task & Comment Flow', () => {
     console.log('Milestone options:', msOptions);
     await milestoneSelect.selectOption({ label: milestoneName });
 
-    await page.getByTestId('task-type-select').selectOption('task');
+    await page.getByTestId('task-type-select').selectOption('issue');
     await page.waitForTimeout(300);
 
     const createTaskResponsePromise = page.waitForResponse((response) => {