hzhang
03b89a547c
Two fixes surfaced by sim e2e test (which otherwise passed full
lifecycle: created → signup_open → 3 signups → allocator → debating
→ arguments → verdict gate (409 early, 201 after debate_end_at) →
completed).
1) MySQL TIMESTAMP rejects RFC3339-with-Z strings — passing those as
sqlx parameters fails with "Incorrect datetime value". Changed
CreateTopicInput lifecycle fields from string to time.Time; the
handler parses+UTCs in validateLifecycleTimes (which now returns
the parsed array along with the validation result) and passes
time.Time to the store. The mysql driver formats correctly.
2) splitSQL was naive `strings.Split(s, ";")` which split inside
comments — the 001 migration had a few `--` lines containing `;`
("signup_close_at; immutable", etc) which broke. Migration text
tidied to not use `;` inside comments, AND splitSQL upgraded to
skip both `-- ...` and `/* ... */` comment regions before splitting.
Sim verified — clean apply on fresh MySQL.
119 lines
3.3 KiB
Go
119 lines
3.3 KiB
Go
package store
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"errors"
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/google/uuid"
|
|
"github.com/jmoiron/sqlx"
|
|
|
|
"git.hangman-lab.top/hzhang/Dialectic.Backend/internal/models"
|
|
)
|
|
|
|
var ErrNotFound = errors.New("not found")
|
|
|
|
type TopicStore struct {
|
|
db *sqlx.DB
|
|
}
|
|
|
|
func NewTopicStore(db *sqlx.DB) *TopicStore { return &TopicStore{db: db} }
|
|
|
|
type CreateTopicInput struct {
|
|
Title string
|
|
Summary string
|
|
Visibility models.Visibility
|
|
VerdictSchemaID string
|
|
SignupOpenAt time.Time
|
|
SignupCloseAt time.Time
|
|
DebateStartAt time.Time
|
|
DebateEndAt time.Time
|
|
CreatorUserID string
|
|
}
|
|
|
|
func (s *TopicStore) Create(ctx context.Context, in CreateTopicInput) (*models.Topic, error) {
|
|
id := uuid.NewString()
|
|
_, err := s.db.ExecContext(ctx, `
|
|
INSERT INTO topics (id, title, summary, visibility, verdict_schema_id,
|
|
signup_open_at, signup_close_at, debate_start_at, debate_end_at, creator_user_id)
|
|
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`,
|
|
id, in.Title, in.Summary, in.Visibility, in.VerdictSchemaID,
|
|
in.SignupOpenAt, in.SignupCloseAt, in.DebateStartAt, in.DebateEndAt, in.CreatorUserID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("insert topic: %w", err)
|
|
}
|
|
return s.GetByID(ctx, id)
|
|
}
|
|
|
|
func (s *TopicStore) GetByID(ctx context.Context, id string) (*models.Topic, error) {
|
|
var t models.Topic
|
|
err := s.db.GetContext(ctx, &t, `SELECT * FROM topics WHERE id = ?`, id)
|
|
if errors.Is(err, sql.ErrNoRows) {
|
|
return nil, ErrNotFound
|
|
}
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &t, nil
|
|
}
|
|
|
|
type ListFilter struct {
|
|
Status string // empty = all
|
|
Visibility string // empty = all
|
|
Limit int // 0 = default 50
|
|
Offset int
|
|
}
|
|
|
|
func (s *TopicStore) List(ctx context.Context, f ListFilter) ([]models.Topic, error) {
|
|
if f.Limit <= 0 || f.Limit > 200 {
|
|
f.Limit = 50
|
|
}
|
|
q := "SELECT * FROM topics"
|
|
args := []any{}
|
|
var clauses []string
|
|
if f.Status != "" {
|
|
clauses = append(clauses, "status = ?")
|
|
args = append(args, f.Status)
|
|
}
|
|
if f.Visibility != "" {
|
|
clauses = append(clauses, "visibility = ?")
|
|
args = append(args, f.Visibility)
|
|
}
|
|
if len(clauses) > 0 {
|
|
q += " WHERE " + strings.Join(clauses, " AND ")
|
|
}
|
|
q += " ORDER BY created_at DESC LIMIT ? OFFSET ?"
|
|
args = append(args, f.Limit, f.Offset)
|
|
|
|
var rows []models.Topic
|
|
if err := s.db.SelectContext(ctx, &rows, q, args...); err != nil {
|
|
return nil, err
|
|
}
|
|
return rows, nil
|
|
}
|
|
|
|
// SetStatus is a low-level status update. Most transitions go through
|
|
// the orchestrator's tx-wrapped paths; this is for the verdict handler
|
|
// (debating → completed on successful judge submission) and admin tools.
|
|
func (s *TopicStore) SetStatus(ctx context.Context, id string, status models.TopicStatus) (*models.Topic, error) {
|
|
if _, err := s.db.ExecContext(ctx,
|
|
`UPDATE topics SET status = ? WHERE id = ?`, status, id); err != nil {
|
|
return nil, err
|
|
}
|
|
return s.GetByID(ctx, id)
|
|
}
|
|
|
|
// SetVisibility flips public/private; records who/when. Returns updated row.
|
|
func (s *TopicStore) SetVisibility(ctx context.Context, id string, v models.Visibility, byUserID string) (*models.Topic, error) {
|
|
_, err := s.db.ExecContext(ctx, `
|
|
UPDATE topics SET visibility = ?, visibility_changed_by = ?, visibility_changed_at = CURRENT_TIMESTAMP
|
|
WHERE id = ?`, v, byUserID, id)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return s.GetByID(ctx, id)
|
|
}
|