5 Commits

Author SHA1 Message Date
428fc254ee fix(plugin): lift calendarScheduler to module scope (multi-register singleton)
Trying the prior multi-agent-handle fix in dind-t2 surfaced a second bug
that PR #7 didn't reach: `harborforge_calendar_status` still returned
`Calendar scheduler not running` even though the gateway log showed the
scheduler had started 30+ seconds before the agent's call.

## Root cause

`register()` is invoked once per agent — `grep -c "HarborForge plugin
registered" /tmp/gw-stdout.log` reports 5 for a 5-agent claw. Every
invocation creates its own `let calendarScheduler` closure binding. But
`gateway_start` fires once and we only call `startCalendarScheduler()`
through that single hook, so exactly one of the five closures sees the
handle and the other four keep their bindings at `null`.

The host's tool router picks one of the five duplicate
`harborforge_calendar_status` registrations to dispatch to — most of the
time it's one of the four "null" closures, which is why every wakeup the
agent saw `Calendar scheduler not running`.

## Fix

Lift `let calendarScheduler` out of `register()` and into module scope.
All five register-call closures now reference the same binding; once the
single `gateway_start` initialises it, every tool sees it.

`startCalendarScheduler()` now early-returns when `calendarScheduler` is
already set, so duplicate `gateway_start` firings (if the host ever does
that) don't double-install intervals.

Bumps version 0.3.2 → 0.3.3.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-21 10:54:36 +01:00
h z
ff9929ad31 Merge pull request 'fix: real per-agent slot handle for multi-agent calendar tools' (#7) from fix/multi-agent-scheduler-handle into main 2026-05-21 09:39:51 +00:00
07a07b6876 fix(plugin): real per-agent slot handle for multi-agent calendar tools
In multi-agent sync mode every harborforge_calendar_* tool was returning
`calendarScheduler.<method> is not a function`. The cause: index.ts replaced
`calendarScheduler` (typed `CalendarScheduler | null`) with a `{ stop() }`
stub right after wiring the runSync/runCheck intervals, so `isRunning()`,
`getCurrentSlot()`, `completeCurrentSlot()`, `abortCurrentSlot()`,
`pauseCurrentSlot()`, `resumeCurrentSlot()`, `getState()`,
`isRestartPending()` and `getStateFilePath()` all blew up at call time.

Replaces the stub with a `MultiAgentSchedulerHandle` that:
  - tracks the last slot dispatched per agent (recorded by `wakeAgent`)
  - exposes status/complete/abort/pause/resume taking the calling agentId
  - resolves the implicit "current slot" via woken-cursor first then a
    cache scan over not_started/deferred/ongoing slots
  - PATCHes via `bridge.updateSlotAs(agentId, …)` so audit headers reflect
    the real caller (bridge constructor agentId is 'unused' in multi-agent)
  - mirrors the legacy `isRunning/isProcessing/getState/...` surface so
    the single-agent fallback (`CalendarScheduler`) keeps working unchanged

Each calendar tool factory now takes `OpenClawPluginToolContext`, reads
`ctx.agentId`, and dispatches through the handle. Single-agent path
(when `calendarScheduler` is a real `CalendarScheduler`) is preserved
behind `instanceof` checks.

Drops the dead `trackSessionCompletion` poll loop (only definition, no
caller) which referenced the removed `completeCurrentSlot`. Bumps
plugin version 0.2.0 → 0.3.2.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-21 10:38:57 +01:00
h z
a003416e56 Merge pull request 'fix: wake dedupe + inline slot context + complete contracts.tools' (#6) from fix/wake-dedupe-and-contracts into main 2026-05-20 14:48:06 +00:00
9ba591795b fix: wake dedupe + inline slot context + complete contracts.tools
Three issues making HF→agent wakeup unusable in practice, surfaced by
DinD sim end-to-end test (recruiter agent + slot for 招募 manager task):

1. **Plugin re-woke the same slot every 30s.** The inline runCheck only
   destructured agentId from scheduleCache.getAgentsWithDueSlots() and
   dropped the slots array, then called wakeAgent without recording the
   wake. The simplified inline scheduler also never PATCHes slot status
   server-side from not_started→ongoing, so the next 30s check sees the
   slot still due and wakes again. After 4 wakes the agent's wakeup
   session was full of WAKEUP_OK noise.

   Fix: keep slots in runCheck, add an in-memory wakedSlotKeys set
   keyed by (agentId, slotId|virtual_id|scheduled_at). Dedupe on this
   set; clear it inside the sync interval (fresh wake budget per sync).
   Server-side slot transition still TODO (requires re-introducing the
   CalendarScheduler class path or PATCH /calendar/slots/.../agent-update
   here); the dedupe at least stops the wake spam.

2. **Wakeup message had no slot context.** The wakeup body just said
   'follow hf-wakeup workflow' with no slot id/event_data/task_code.
   The agent then had to call harborforge_calendar_status to learn
   anything — which itself is broken in the simplified scheduler (it
   queries a CalendarScheduler instance that never gets created).

   Fix: pass dueSlots into wakeAgent and inline the highest-priority
   slot's {slot_id, scheduled_at, priority, slot_type, event_data} as
   a JSON block in the wakeup message. The agent reads event_data.
   task_code directly and routes via workflow_lookup without any
   round-trip. Per PLG-CAL-001 docs in hf-hangman-lab SKILL.md, this
   is the documented contract; we are bringing the message in line.

3. **contracts.tools listed 5 of the 9 registered tools.** Manifest had
   harborforge_status/telemetry/monitor_telemetry/calendar_status/
   calendar_complete. Code also registers calendar_abort, calendar_pause,
   calendar_resume, harborforge_restart_status. With the new OpenClaw
   plugin host enforcement (same gotcha that bit Meridian — see
   zhi/Meridian#2), undeclared tools are silently dropped from the
   agent's tool list, so abort/pause/resume cannot be called by the
   agent. plugin doctor was emitting:
   'plugin tool is undeclared (harbor-forge): harborforge_calendar_abort'
   for each missing tool.

   Fix: add the 4 missing tool names to contracts.tools.

Also use api.config as the primary config source in wakeAgent (current
public API), falling back to runtime.config.loadConfig() for older
hosts — same pattern as the Meridian fix.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-20 12:02:25 +01:00
6 changed files with 479 additions and 82 deletions

View File

@@ -110,6 +110,23 @@ export class CalendarBridgeClient {
return this.sendBoolean('PATCH', url, update); return this.sendBoolean('PATCH', url, update);
} }
/**
* Same as {@link updateSlot} but overrides the `X-Agent-ID` header for a
* single call. Used by the multi-agent scheduler handle where the bridge
* client is shared across agents and the constructor agentId is `'unused'`.
*
* Backend identifies the slot purely by `slotId`; the header is informational
* for audit. Passing the calling agent's id keeps audit/log lines correct.
*/
async updateSlotAs(
agentId: string,
slotId: number,
update: SlotAgentUpdate
): Promise<boolean> {
const url = `${this.baseUrl}/calendar/slots/${slotId}/agent-update`;
return this.sendBooleanAs(agentId, 'PATCH', url, update);
}
/** /**
* Update a virtual (plan-generated) slot's status after agent execution. * Update a virtual (plan-generated) slot's status after agent execution.
* *
@@ -264,6 +281,15 @@ export class CalendarBridgeClient {
} }
private async sendBoolean(method: 'POST' | 'PATCH', url: string, body: unknown): Promise<boolean> { private async sendBoolean(method: 'POST' | 'PATCH', url: string, body: unknown): Promise<boolean> {
return this.sendBooleanAs(this.config.agentId, method, url, body);
}
private async sendBooleanAs(
agentId: string,
method: 'POST' | 'PATCH',
url: string,
body: unknown
): Promise<boolean> {
const controller = new AbortController(); const controller = new AbortController();
const timeout = setTimeout(() => controller.abort(), this.timeoutMs); const timeout = setTimeout(() => controller.abort(), this.timeoutMs);
@@ -272,7 +298,7 @@ export class CalendarBridgeClient {
method, method,
headers: { headers: {
'Content-Type': 'application/json', 'Content-Type': 'application/json',
'X-Agent-ID': this.config.agentId, 'X-Agent-ID': agentId,
'X-Claw-Identifier': this.config.clawIdentifier, 'X-Claw-Identifier': this.config.clawIdentifier,
}, },
body: JSON.stringify(body), body: JSON.stringify(body),

View File

@@ -0,0 +1,240 @@
/**
* MultiAgentSchedulerHandle — runtime façade that backs the public
* `harborforge_calendar_*` tools when the plugin runs in multi-agent sync
* mode.
*
* Background
* ----------
* The old single-agent path used `CalendarScheduler` which kept a "current
* slot" cursor and exposed `isRunning() / completeCurrentSlot() / abortCurrentSlot() / …`.
* In multi-agent mode the plugin doesn't own a single cursor — one plugin
* instance services every agent on the claw — so the previous code stubbed the
* `calendarScheduler` variable to `{ stop() }`. That made every tool fail
* with `calendarScheduler.<method> is not a function`.
*
* This handle restores the same surface area (`isRunning / getCurrentSlot /
* completeCurrentSlot / …`) but resolves the "current slot" per caller via
* the agentId/sessionKey supplied by the OpenClaw tool-factory context. The
* scheduler records the slot it just dispatched to each agent in
* {@link recordWoken}; the tool resolves the caller, looks up the last woken
* slot, and PATCHes the backend via the shared bridge.
*
* Tools must pass the calling agentId (from `OpenClawPluginToolContext.agentId`)
* into every method. The handle does not consult `process.env.AGENT_ID` — the
* gateway sets that to the host's primary agent which is meaningless in
* multi-agent mode.
*/
import type { CalendarBridgeClient } from './calendar-bridge.js';
import type { MultiAgentScheduleCache, CachedSlot } from './schedule-cache.js';
import { SlotStatus } from './types.js';
export interface MultiAgentSchedulerHandleParams {
bridge: CalendarBridgeClient;
cache: MultiAgentScheduleCache;
/** setInterval handles cleared on stop() */
syncHandle: ReturnType<typeof setInterval>;
checkHandle: ReturnType<typeof setInterval>;
logger: {
info: (...args: unknown[]) => void;
warn: (...args: unknown[]) => void;
error: (...args: unknown[]) => void;
};
}
/** Last slot we dispatched to an agent. Used as the implicit "current slot". */
export interface WokenSlot {
agentId: string;
slotId: number | null;
virtualId: string | null;
scheduledAt: string | null;
slotType: string | null;
estimatedDuration: number | null;
wokenAt: string;
}
/** Public surface — mirrors the relevant subset of the old single-agent scheduler. */
export class MultiAgentSchedulerHandle {
private readonly bridge: CalendarBridgeClient;
private readonly cache: MultiAgentScheduleCache;
private readonly syncHandle: ReturnType<typeof setInterval>;
private readonly checkHandle: ReturnType<typeof setInterval>;
private readonly logger: MultiAgentSchedulerHandleParams['logger'];
private readonly woken: Map<string, WokenSlot> = new Map();
private stopped = false;
constructor(params: MultiAgentSchedulerHandleParams) {
this.bridge = params.bridge;
this.cache = params.cache;
this.syncHandle = params.syncHandle;
this.checkHandle = params.checkHandle;
this.logger = params.logger;
}
// ---------- lifecycle ----------
/** True while the sync/check intervals are still ticking. */
isRunning(): boolean {
return !this.stopped;
}
/** Always false in multi-agent mode — there is no per-instance work queue. */
isProcessing(): boolean {
return false;
}
stop(): void {
if (this.stopped) return;
this.stopped = true;
clearInterval(this.syncHandle);
clearInterval(this.checkHandle);
this.logger.info('Calendar scheduler stopped (multi-agent mode)');
}
// ---------- wake bookkeeping ----------
/** Record that we just dispatched a slot to `agentId`. */
recordWoken(agentId: string, slot: CachedSlot): void {
this.woken.set(agentId, {
agentId,
slotId: typeof slot.id === 'number' ? slot.id : null,
virtualId: typeof slot.virtual_id === 'string' ? slot.virtual_id : null,
scheduledAt: typeof slot.scheduled_at === 'string' ? slot.scheduled_at : null,
slotType: typeof slot.slot_type === 'string' ? slot.slot_type : null,
estimatedDuration:
typeof slot.estimated_duration === 'number' ? slot.estimated_duration : null,
wokenAt: new Date().toISOString(),
});
}
// ---------- per-agent reads ----------
/**
* The slot most recently dispatched to `agentId`, or null if we never woke
* them (e.g. tool called outside a wakeup). Callers can fall back to
* scanning {@link cachedSlotsFor} for `not_started`/`deferred` slots if they
* want a heuristic "current".
*/
getWokenSlot(agentId: string | null | undefined): WokenSlot | null {
if (!agentId) return null;
return this.woken.get(agentId) ?? null;
}
/** Today's cached slots for an agent (whatever runSync last pulled). */
cachedSlotsFor(agentId: string | null | undefined): CachedSlot[] {
if (!agentId) return [];
return this.cache.getAgentSlots(agentId);
}
/**
* Implicit "current" slot: the last woken slot if we know about it,
* otherwise the highest-priority `not_started`/`deferred`/`ongoing` cached
* slot for the agent (so a tool called between sync windows still finds
* something sensible).
*/
resolveCurrentSlot(agentId: string | null | undefined): WokenSlot | null {
const woken = this.getWokenSlot(agentId);
if (woken) return woken;
if (!agentId) return null;
const slots = this.cache.getAgentSlots(agentId)
.filter((s) => s.status === 'not_started' || s.status === 'deferred' || s.status === 'ongoing')
.sort((a, b) => (b.priority ?? 0) - (a.priority ?? 0));
const top = slots[0];
if (!top) return null;
return {
agentId,
slotId: typeof top.id === 'number' ? top.id : null,
virtualId: typeof top.virtual_id === 'string' ? top.virtual_id : null,
scheduledAt: typeof top.scheduled_at === 'string' ? top.scheduled_at : null,
slotType: typeof top.slot_type === 'string' ? top.slot_type : null,
estimatedDuration:
typeof top.estimated_duration === 'number' ? top.estimated_duration : null,
wokenAt: 'inferred-from-cache',
};
}
// ---------- per-agent writes ----------
async completeSlot(agentId: string, actualDurationMinutes: number): Promise<SlotMutationResult> {
return this.transition(agentId, SlotStatus.FINISHED, { actual_duration: actualDurationMinutes });
}
async abortSlot(agentId: string, reason?: string): Promise<SlotMutationResult> {
if (reason) this.logger.info(`Aborting slot for ${agentId}: ${reason}`);
return this.transition(agentId, SlotStatus.ABORTED);
}
async pauseSlot(agentId: string): Promise<SlotMutationResult> {
return this.transition(agentId, SlotStatus.PAUSED);
}
/** Resume puts the slot back into `ongoing` so it isn't picked up as `not_started`. */
async resumeSlot(agentId: string): Promise<SlotMutationResult> {
return this.transition(agentId, SlotStatus.ONGOING);
}
private async transition(
agentId: string,
status: SlotStatus,
extra: { actual_duration?: number } = {}
): Promise<SlotMutationResult> {
const slot = this.resolveCurrentSlot(agentId);
if (!slot) {
return { ok: false, error: `No tracked slot for agent '${agentId}'` };
}
if (slot.slotId == null && slot.virtualId == null) {
return { ok: false, error: 'Resolved slot has neither id nor virtual_id' };
}
const update = { status, ...extra };
try {
if (slot.slotId != null) {
const ok = await this.bridge.updateSlotAs(agentId, slot.slotId, update);
if (!ok) return { ok: false, error: `Backend rejected slot ${slot.slotId}${status}` };
// Clear the wake cursor only on terminal transitions so re-wakes don't
// re-trigger the same slot mutation.
if (status === SlotStatus.FINISHED || status === SlotStatus.ABORTED) {
this.woken.delete(agentId);
}
return { ok: true, slot, status };
}
// virtual slot path: bridge has updateVirtualSlot
const materialised = await this.bridge.updateVirtualSlot(slot.virtualId!, update);
if (!materialised) {
return { ok: false, error: `Backend rejected virtual slot ${slot.virtualId}` };
}
if (status === SlotStatus.FINISHED || status === SlotStatus.ABORTED) {
this.woken.delete(agentId);
}
return { ok: true, slot, status, materialised };
} catch (err: unknown) {
const msg = (err as { message?: string } | undefined)?.message ?? String(err);
return { ok: false, error: msg };
}
}
// ---------- gateway-restart parity (no-op in multi-agent mode) ----------
/** Multi-agent scheduler does not persist a `ScheduledGatewayRestart` flag. */
isRestartPending(): boolean {
return false;
}
getStateFilePath(): string | null {
return null;
}
getState(): { mode: 'multi-agent'; agents: number; lastWoken: WokenSlot[] } {
return {
mode: 'multi-agent',
agents: this.cache.getStatus().agentCount,
lastWoken: Array.from(this.woken.values()),
};
}
}
export interface SlotMutationResult {
ok: boolean;
error?: string;
status?: SlotStatus;
slot?: WokenSlot;
/** Present only when a virtual slot was materialised. */
materialised?: unknown;
}

View File

@@ -14,6 +14,7 @@
import { hostname, freemem, totalmem, uptime, loadavg, platform } from 'node:os'; import { hostname, freemem, totalmem, uptime, loadavg, platform } from 'node:os';
import { definePluginEntry } from 'openclaw/plugin-sdk/plugin-entry'; import { definePluginEntry } from 'openclaw/plugin-sdk/plugin-entry';
import { MultiAgentScheduleCache } from './calendar/schedule-cache.js'; import { MultiAgentScheduleCache } from './calendar/schedule-cache.js';
import { MultiAgentSchedulerHandle } from './calendar/multi-agent-handle.js';
import { getPluginConfig } from './core/config.js'; import { getPluginConfig } from './core/config.js';
import { MonitorBridgeClient, type OpenClawMeta } from './core/monitor-bridge.js'; import { MonitorBridgeClient, type OpenClawMeta } from './core/monitor-bridge.js';
import type { OpenClawAgentInfo } from './core/openclaw-agents.js'; import type { OpenClawAgentInfo } from './core/openclaw-agents.js';
@@ -21,11 +22,28 @@ import { registerGatewayStartHook } from './hooks/gateway-start.js';
import { registerGatewayStopHook } from './hooks/gateway-stop.js'; import { registerGatewayStopHook } from './hooks/gateway-stop.js';
import { import {
createCalendarBridgeClient, createCalendarBridgeClient,
createCalendarScheduler,
CalendarScheduler, CalendarScheduler,
AgentWakeContext,
} from './calendar/index.js'; } from './calendar/index.js';
// ---------------------------------------------------------------------------
// Module-scope calendar scheduler singleton.
//
// `register()` is called multiple times per gateway boot — once per agent
// (we see 5 `HarborForge plugin registered` lines for 5 agents on dind-t2).
// `gateway_start` only fires once, so before this lift the
// `startCalendarScheduler()` setup ran inside ONE closure while four other
// closures kept their own `calendarScheduler = null`. Whichever of the five
// tool registrations the gateway picked at call time was effectively a coin
// flip, and four times out of five `harborforge_calendar_status` returned
// `Calendar scheduler not running` even though the scheduler was active.
//
// Keeping the singleton at module scope removes the per-`register()` shadow:
// the scheduler is started once, every closure reads the same binding, and
// `startCalendarScheduler()` is idempotent so duplicate `gateway_start`
// firings are harmless.
// ---------------------------------------------------------------------------
let calendarScheduler: MultiAgentSchedulerHandle | CalendarScheduler | null = null;
interface PluginAPI { interface PluginAPI {
logger: { logger: {
info: (...args: any[]) => void; info: (...args: any[]) => void;
@@ -109,7 +127,7 @@ function register(api: PluginAPI): void {
}, },
openclaw: { openclaw: {
version: api.runtime?.version || api.version || 'unknown', version: api.runtime?.version || api.version || 'unknown',
pluginVersion: '0.3.1', // Bumped for PLG-CAL-004 pluginVersion: '0.3.3', // Bumped for PLG-CAL-004
}, },
timestamp: new Date().toISOString(), timestamp: new Date().toISOString(),
}; };
@@ -118,8 +136,9 @@ function register(api: PluginAPI): void {
// Periodic metadata push interval handle // Periodic metadata push interval handle
let metaPushInterval: ReturnType<typeof setInterval> | null = null; let metaPushInterval: ReturnType<typeof setInterval> | null = null;
// Calendar scheduler instance // (calendarScheduler is module-scope — see top of file for the why.
let calendarScheduler: CalendarScheduler | null = null; // Tools and lifecycle hooks all reference the same binding so the
// multi-register/single-start mismatch can't shadow them again.)
/** /**
* Push OpenClaw metadata to the Monitor bridge. * Push OpenClaw metadata to the Monitor bridge.
@@ -143,7 +162,7 @@ function register(api: PluginAPI): void {
const meta: OpenClawMeta = { const meta: OpenClawMeta = {
version: api.runtime?.version || api.version || 'unknown', version: api.runtime?.version || api.version || 'unknown',
plugin_version: '0.3.1', plugin_version: '0.3.3',
agents: agentNames.map(name => ({ name })), agents: agentNames.map(name => ({ name })),
}; };
@@ -197,7 +216,18 @@ function register(api: PluginAPI): void {
* Wake agent via dispatchInboundMessage — same mechanism used by Discord plugin. * Wake agent via dispatchInboundMessage — same mechanism used by Discord plugin.
* Direct in-process call, no WebSocket or CLI needed. * Direct in-process call, no WebSocket or CLI needed.
*/ */
async function wakeAgent(agentId: string): Promise<boolean> { async function wakeAgent(
agentId: string,
dueSlots?: Array<{
id?: number | null;
virtual_id?: string | null;
event_data?: any;
scheduled_at?: string;
priority?: number;
slot_type?: string;
[k: string]: unknown;
}>
): Promise<boolean> {
logger.info(`Waking agent ${agentId}: has due slots`); logger.info(`Waking agent ${agentId}: has due slots`);
const sessionKey = `agent:${agentId}:hf-wakeup`; const sessionKey = `agent:${agentId}:hf-wakeup`;
@@ -208,13 +238,39 @@ function register(api: PluginAPI): void {
/* webpackIgnore: true */ sdkPath /* webpackIgnore: true */ sdkPath
); );
const cfg = api.runtime?.config?.loadConfig?.(); // api.config first (current public API). Fall back to deprecated
// runtime.config.loadConfig() for older host versions. Both should
// contain agents.list / channels for dispatch routing.
const cfg = (api as any).config ?? api.runtime?.config?.loadConfig?.();
if (!cfg) { if (!cfg) {
logger.error('Cannot load OpenClaw config for dispatch'); logger.error('Cannot load OpenClaw config for dispatch');
return false; return false;
} }
const wakeupMessage = `You have due slots. Follow the \`hf-wakeup\` workflow of skill \`hf-hangman-lab\` to proceed. Only reply \`WAKEUP_OK\` in this session.`; // Inline the highest-priority due slot's context so the agent does
// not need a second round-trip to harborforge_calendar_status. The
// agent can read event_data.task_code / task_title etc. directly.
let slotBlock = '';
const top = dueSlots && dueSlots.length ? dueSlots[0] : undefined;
if (top) {
slotBlock = `\n\nMatching slot:\n\`\`\`json\n${JSON.stringify(
{
slot_id: top.id ?? null,
virtual_id: top.virtual_id ?? null,
scheduled_at: top.scheduled_at ?? null,
priority: top.priority ?? null,
slot_type: top.slot_type ?? null,
event_data: top.event_data ?? null,
},
null,
2
)}\n\`\`\``;
}
const wakeupMessage =
`You have due slots. Follow the \`hf-wakeup\` workflow of skill ` +
`\`hf-hangman-lab\` to proceed. Only reply \`WAKEUP_OK\` in this ` +
`session.${slotBlock}`;
const result = await dispatchInboundMessageWithDispatcher({ const result = await dispatchInboundMessageWithDispatcher({
ctx: { ctx: {
@@ -243,42 +299,23 @@ function register(api: PluginAPI): void {
} }
} }
/** // (trackSessionCompletion removed — legacy single-agent poll loop that
* Track session completion and update slot status accordingly. // called calendarScheduler.completeCurrentSlot. The multi-agent path
*/ // closes slots via the harborforge_calendar_complete tool, driven by
function trackSessionCompletion(sessionId: string, context: AgentWakeContext): void { // the agent itself, not by a timer.)
// Poll for session completion (simplified approach)
// In production, this would use webhooks or event streaming
const pollInterval = 30000; // 30 seconds
const maxDuration = context.slot.estimated_duration * 60 * 1000; // Convert to ms
const startTime = Date.now();
const poll = async () => {
if (!calendarScheduler) return;
const elapsed = Date.now() - startTime;
// Check if session is complete (would use actual API in production)
// For now, estimate completion based on duration
if (elapsed >= maxDuration) {
// Assume completion
const actualMinutes = Math.round(elapsed / 60000);
await calendarScheduler.completeCurrentSlot(actualMinutes);
return;
}
// Continue polling
setTimeout(poll, pollInterval);
};
// Start polling
setTimeout(poll, pollInterval);
}
/** /**
* Initialize and start the calendar scheduler. * Initialize and start the calendar scheduler.
*
* Idempotent — `gateway_start` may fire once per `register()` invocation
* (the host calls `register` per agent), and we only want one set of
* sync/check intervals across the whole process.
*/ */
function startCalendarScheduler(): void { function startCalendarScheduler(): void {
if (calendarScheduler) {
logger.info('Calendar scheduler already started, skipping duplicate gateway_start');
return;
}
const live = resolveConfig(); const live = resolveConfig();
// Create bridge client (claw-instance level, not per-agent) // Create bridge client (claw-instance level, not per-agent)
@@ -308,38 +345,76 @@ function register(api: PluginAPI): void {
} }
} }
// Track wakes already dispatched for a slot in the current sync
// window — the simplified inline scheduler does not PATCH slot
// status server-side, so without dedupe the check loop re-wakes
// the same slot every 30s. Set is cleared by runSync (fresh wake
// budget per sync).
const wakedSlotKeys = new Set<string>();
// Check: find agents with due slots and wake them // Check: find agents with due slots and wake them
async function runCheck() { async function runCheck() {
const now = new Date(); const now = new Date();
const agentsWithDue = scheduleCache.getAgentsWithDueSlots(now); const agentsWithDue = scheduleCache.getAgentsWithDueSlots(now);
for (const { agentId } of agentsWithDue) { for (const { agentId, slots } of agentsWithDue) {
// Check if agent is busy // Filter out slots we've already woken this sync window
const status = await calendarBridge.getAgentStatus(agentId); const fresh = slots.filter((s) => {
const key = `${agentId}::${s.id ?? s.virtual_id ?? s.scheduled_at}`;
if (wakedSlotKeys.has(key)) return false;
return true;
});
if (fresh.length === 0) continue;
// Check if agent is busy (best effort; backend may 405 the GET
// — treat unknown as not-busy so wakeup still fires)
let status: string | null = null;
try {
status = await calendarBridge.getAgentStatus(agentId);
} catch {
status = null;
}
if (status === 'busy' || status === 'offline' || status === 'exhausted') { if (status === 'busy' || status === 'offline' || status === 'exhausted') {
continue; continue;
} }
// Wake the agent // Wake the agent with the slot context inlined
await wakeAgent(agentId); const ok = await wakeAgent(agentId, fresh);
if (ok) {
// Top slot is the one inlined in the wakeup message; record it as
// the agent's "current" so harborforge_calendar_complete/abort/…
// can resolve a slot without an explicit param.
const top = fresh[0];
if (top && calendarScheduler instanceof MultiAgentSchedulerHandle) {
calendarScheduler.recordWoken(agentId, top);
}
for (const s of fresh) {
const key = `${agentId}::${s.id ?? s.virtual_id ?? s.scheduled_at}`;
wakedSlotKeys.add(key);
}
}
} }
} }
// Initial sync // Initial sync (also resets the wake-dedupe window)
runSync(); const runSyncReset = async () => {
wakedSlotKeys.clear();
await runSync();
};
runSyncReset();
// Start intervals // Start intervals
const syncHandle = setInterval(runSync, SYNC_INTERVAL_MS); const syncHandle = setInterval(runSyncReset, SYNC_INTERVAL_MS);
const checkHandle = setInterval(runCheck, CHECK_INTERVAL_MS); const checkHandle = setInterval(runCheck, CHECK_INTERVAL_MS);
// Store handles for cleanup (reuse calendarScheduler variable) // Install the multi-agent handle so calendar tools resolve per-caller.
(calendarScheduler as any) = { calendarScheduler = new MultiAgentSchedulerHandle({
stop() { bridge: calendarBridge,
clearInterval(syncHandle); cache: scheduleCache,
clearInterval(checkHandle); syncHandle,
logger.info('Calendar scheduler stopped'); checkHandle,
}, logger,
}; });
logger.info('Calendar scheduler started (multi-agent sync mode)'); logger.info('Calendar scheduler started (multi-agent sync mode)');
} }
@@ -376,7 +451,7 @@ function register(api: PluginAPI): void {
}); });
// Tool: plugin status // Tool: plugin status
api.registerTool(() => ({ api.registerTool((ctx) => ({
name: 'harborforge_status', name: 'harborforge_status',
description: 'Get HarborForge plugin status and current telemetry snapshot', description: 'Get HarborForge plugin status and current telemetry snapshot',
parameters: { parameters: {
@@ -395,13 +470,27 @@ function register(api: PluginAPI): void {
: { connected: false, error: 'Monitor bridge unreachable' }; : { connected: false, error: 'Monitor bridge unreachable' };
} }
// Get calendar scheduler status // Get calendar scheduler status. In multi-agent mode `currentSlot`
const calendarStatus = calendarScheduler ? { // depends on the caller, so look it up via ctx.agentId.
const callerAgentId = ctx?.agentId ?? resolveAgentId();
const calendarStatus = calendarScheduler
? calendarScheduler instanceof MultiAgentSchedulerHandle
? {
running: calendarScheduler.isRunning(), running: calendarScheduler.isRunning(),
processing: calendarScheduler.isProcessing(), processing: calendarScheduler.isProcessing(),
mode: 'multi-agent',
callerAgentId,
currentSlot: calendarScheduler.resolveCurrentSlot(callerAgentId),
isRestartPending: calendarScheduler.isRestartPending(),
}
: {
running: calendarScheduler.isRunning(),
processing: calendarScheduler.isProcessing(),
mode: 'single-agent',
currentSlot: calendarScheduler.getCurrentSlot(), currentSlot: calendarScheduler.getCurrentSlot(),
isRestartPending: calendarScheduler.isRestartPending(), isRestartPending: calendarScheduler.isRestartPending(),
} : null; }
: null;
return { return {
enabled: live.enabled !== false, enabled: live.enabled !== false,
@@ -460,7 +549,7 @@ function register(api: PluginAPI): void {
})); }));
// Tool: calendar slot management // Tool: calendar slot management
api.registerTool(() => ({ api.registerTool((ctx) => ({
name: 'harborforge_calendar_status', name: 'harborforge_calendar_status',
description: 'Get current calendar scheduler status and pending slots', description: 'Get current calendar scheduler status and pending slots',
parameters: { parameters: {
@@ -471,10 +560,24 @@ function register(api: PluginAPI): void {
if (!calendarScheduler) { if (!calendarScheduler) {
return { error: 'Calendar scheduler not running' }; return { error: 'Calendar scheduler not running' };
} }
const callerAgentId = ctx?.agentId ?? resolveAgentId();
if (calendarScheduler instanceof MultiAgentSchedulerHandle) {
return { return {
running: calendarScheduler.isRunning(), running: calendarScheduler.isRunning(),
processing: calendarScheduler.isProcessing(), processing: calendarScheduler.isProcessing(),
mode: 'multi-agent',
callerAgentId,
currentSlot: calendarScheduler.resolveCurrentSlot(callerAgentId),
agentSlots: calendarScheduler.cachedSlotsFor(callerAgentId),
state: calendarScheduler.getState(),
isRestartPending: calendarScheduler.isRestartPending(),
stateFilePath: calendarScheduler.getStateFilePath(),
};
}
return {
running: calendarScheduler.isRunning(),
processing: calendarScheduler.isProcessing(),
mode: 'single-agent',
currentSlot: calendarScheduler.getCurrentSlot(), currentSlot: calendarScheduler.getCurrentSlot(),
state: calendarScheduler.getState(), state: calendarScheduler.getState(),
isRestartPending: calendarScheduler.isRestartPending(), isRestartPending: calendarScheduler.isRestartPending(),
@@ -484,7 +587,7 @@ function register(api: PluginAPI): void {
})); }));
// Tool: complete current slot (for agent to report completion) // Tool: complete current slot (for agent to report completion)
api.registerTool(() => ({ api.registerTool((ctx) => ({
name: 'harborforge_calendar_complete', name: 'harborforge_calendar_complete',
description: 'Complete the current calendar slot with actual duration', description: 'Complete the current calendar slot with actual duration',
parameters: { parameters: {
@@ -501,14 +604,20 @@ function register(api: PluginAPI): void {
if (!calendarScheduler) { if (!calendarScheduler) {
return { error: 'Calendar scheduler not running' }; return { error: 'Calendar scheduler not running' };
} }
if (calendarScheduler instanceof MultiAgentSchedulerHandle) {
const agentId = ctx?.agentId ?? resolveAgentId();
const res = await calendarScheduler.completeSlot(agentId, params.actualDurationMinutes);
return res.ok
? { success: true, message: 'Slot completed', slot: res.slot }
: { error: res.error };
}
await calendarScheduler.completeCurrentSlot(params.actualDurationMinutes); await calendarScheduler.completeCurrentSlot(params.actualDurationMinutes);
return { success: true, message: 'Slot completed' }; return { success: true, message: 'Slot completed' };
}, },
})); }));
// Tool: abort current slot (for agent to report failure) // Tool: abort current slot (for agent to report failure)
api.registerTool(() => ({ api.registerTool((ctx) => ({
name: 'harborforge_calendar_abort', name: 'harborforge_calendar_abort',
description: 'Abort the current calendar slot', description: 'Abort the current calendar slot',
parameters: { parameters: {
@@ -524,14 +633,20 @@ function register(api: PluginAPI): void {
if (!calendarScheduler) { if (!calendarScheduler) {
return { error: 'Calendar scheduler not running' }; return { error: 'Calendar scheduler not running' };
} }
if (calendarScheduler instanceof MultiAgentSchedulerHandle) {
const agentId = ctx?.agentId ?? resolveAgentId();
const res = await calendarScheduler.abortSlot(agentId, params.reason);
return res.ok
? { success: true, message: 'Slot aborted', slot: res.slot }
: { error: res.error };
}
await calendarScheduler.abortCurrentSlot(params.reason); await calendarScheduler.abortCurrentSlot(params.reason);
return { success: true, message: 'Slot aborted' }; return { success: true, message: 'Slot aborted' };
}, },
})); }));
// Tool: pause current slot // Tool: pause current slot
api.registerTool(() => ({ api.registerTool((ctx) => ({
name: 'harborforge_calendar_pause', name: 'harborforge_calendar_pause',
description: 'Pause the current calendar slot', description: 'Pause the current calendar slot',
parameters: { parameters: {
@@ -542,14 +657,20 @@ function register(api: PluginAPI): void {
if (!calendarScheduler) { if (!calendarScheduler) {
return { error: 'Calendar scheduler not running' }; return { error: 'Calendar scheduler not running' };
} }
if (calendarScheduler instanceof MultiAgentSchedulerHandle) {
const agentId = ctx?.agentId ?? resolveAgentId();
const res = await calendarScheduler.pauseSlot(agentId);
return res.ok
? { success: true, message: 'Slot paused', slot: res.slot }
: { error: res.error };
}
await calendarScheduler.pauseCurrentSlot(); await calendarScheduler.pauseCurrentSlot();
return { success: true, message: 'Slot paused' }; return { success: true, message: 'Slot paused' };
}, },
})); }));
// Tool: resume current slot // Tool: resume current slot
api.registerTool(() => ({ api.registerTool((ctx) => ({
name: 'harborforge_calendar_resume', name: 'harborforge_calendar_resume',
description: 'Resume the paused calendar slot', description: 'Resume the paused calendar slot',
parameters: { parameters: {
@@ -560,7 +681,13 @@ function register(api: PluginAPI): void {
if (!calendarScheduler) { if (!calendarScheduler) {
return { error: 'Calendar scheduler not running' }; return { error: 'Calendar scheduler not running' };
} }
if (calendarScheduler instanceof MultiAgentSchedulerHandle) {
const agentId = ctx?.agentId ?? resolveAgentId();
const res = await calendarScheduler.resumeSlot(agentId);
return res.ok
? { success: true, message: 'Slot resumed', slot: res.slot }
: { error: res.error };
}
await calendarScheduler.resumeCurrentSlot(); await calendarScheduler.resumeCurrentSlot();
return { success: true, message: 'Slot resumed' }; return { success: true, message: 'Slot resumed' };
}, },

View File

@@ -11,7 +11,11 @@
"harborforge_telemetry", "harborforge_telemetry",
"harborforge_monitor_telemetry", "harborforge_monitor_telemetry",
"harborforge_calendar_status", "harborforge_calendar_status",
"harborforge_calendar_complete" "harborforge_calendar_complete",
"harborforge_calendar_abort",
"harborforge_calendar_pause",
"harborforge_calendar_resume",
"harborforge_restart_status"
] ]
}, },
"configSchema": { "configSchema": {

View File

@@ -9,14 +9,14 @@
"version": "0.2.0", "version": "0.2.0",
"license": "MIT", "license": "MIT",
"devDependencies": { "devDependencies": {
"@types/node": "^20.0.0", "@types/node": "^20.19.41",
"typescript": "^5.0.0" "typescript": "^5.0.0"
} }
}, },
"node_modules/@types/node": { "node_modules/@types/node": {
"version": "20.19.37", "version": "20.19.41",
"resolved": "https://registry.npmjs.org/@types/node/-/node-20.19.37.tgz", "resolved": "https://registry.npmjs.org/@types/node/-/node-20.19.41.tgz",
"integrity": "sha512-8kzdPJ3FsNsVIurqBs7oodNnCEVbni9yUEkaHbgptDACOPW04jimGagZ51E6+lXUwJjgnBw+hyko/lkFWCldqw==", "integrity": "sha512-ECymXOukMnOoVkC2bb1Vc/w/836DXncOg5m8Xj1RH7xSHZJWNYY6Zh7EH477vcnD5egKNNfy2RpNOmuChhFPgQ==",
"dev": true, "dev": true,
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {

View File

@@ -1,6 +1,6 @@
{ {
"name": "harbor-forge-plugin", "name": "harbor-forge-plugin",
"version": "0.2.0", "version": "0.3.3",
"description": "OpenClaw plugin for HarborForge monitor bridge and CLI integration", "description": "OpenClaw plugin for HarborForge monitor bridge and CLI integration",
"type": "module", "type": "module",
"main": "dist/index.js", "main": "dist/index.js",
@@ -10,7 +10,7 @@
"watch": "tsc --watch" "watch": "tsc --watch"
}, },
"devDependencies": { "devDependencies": {
"@types/node": "^20.0.0", "@types/node": "^20.19.41",
"typescript": "^5.0.0" "typescript": "^5.0.0"
}, },
"license": "MIT" "license": "MIT"