From 5a76f61692667915ddfcb3ef546f55cd4cd2fea5 Mon Sep 17 00:00:00 2001 From: Zhi Date: Thu, 12 Mar 2026 22:01:55 +0000 Subject: [PATCH] fix: remove leftover code in get_issue --- app/api/routers/issues.py | 35 ----------------------------------- app/models/models.py | 2 +- 2 files changed, 1 insertion(+), 36 deletions(-) diff --git a/app/api/routers/issues.py b/app/api/routers/issues.py index 2ca4348..14eafbb 100644 --- a/app/api/routers/issues.py +++ b/app/api/routers/issues.py @@ -129,11 +129,6 @@ def get_issue(issue_id: int, db: Session = Depends(get_db)): issue = db.query(models.Issue).filter(models.Issue.id == issue_id).first() if not issue: raise HTTPException(status_code=404, detail="Issue not found") - update_data = issue_update.model_dump(exclude_unset=True) - if "issue_type" in update_data or "issue_subtype" in update_data: - new_type = update_data.get("issue_type", issue.issue_type) - new_subtype = update_data.get("issue_subtype", issue.issue_subtype) - _validate_issue_type_subtype(new_type, new_subtype, require_subtype="issue_type" in update_data) return issue @@ -144,11 +139,6 @@ def update_issue(issue_id: int, issue_update: schemas.IssueUpdate, db: Session = check_project_role(db, current_user.id, issue.project_id, min_role="dev") if not issue: raise HTTPException(status_code=404, detail="Issue not found") - update_data = issue_update.model_dump(exclude_unset=True) - if "issue_type" in update_data or "issue_subtype" in update_data: - new_type = update_data.get("issue_type", issue.issue_type) - new_subtype = update_data.get("issue_subtype", issue.issue_subtype) - _validate_issue_type_subtype(new_type, new_subtype, require_subtype="issue_type" in update_data) for field, value in update_data.items(): setattr(issue, field, value) db.commit() @@ -163,11 +153,6 @@ def delete_issue(issue_id: int, db: Session = Depends(get_db), current_user: mod check_project_role(db, current_user.id, issue.project_id, min_role="mgr") if not issue: raise HTTPException(status_code=404, detail="Issue not found") - update_data = issue_update.model_dump(exclude_unset=True) - if "issue_type" in update_data or "issue_subtype" in update_data: - new_type = update_data.get("issue_type", issue.issue_type) - new_subtype = update_data.get("issue_subtype", issue.issue_subtype) - _validate_issue_type_subtype(new_type, new_subtype, require_subtype="issue_type" in update_data) log_activity(db, "issue.deleted", "issue", issue.id, current_user.id, {"title": issue.title}) db.delete(issue) db.commit() @@ -184,11 +169,6 @@ def transition_issue(issue_id: int, new_status: str, bg: BackgroundTasks, db: Se issue = db.query(models.Issue).filter(models.Issue.id == issue_id).first() if not issue: raise HTTPException(status_code=404, detail="Issue not found") - update_data = issue_update.model_dump(exclude_unset=True) - if "issue_type" in update_data or "issue_subtype" in update_data: - new_type = update_data.get("issue_type", issue.issue_type) - new_subtype = update_data.get("issue_subtype", issue.issue_subtype) - _validate_issue_type_subtype(new_type, new_subtype, require_subtype="issue_type" in update_data) old_status = issue.status issue.status = new_status db.commit() @@ -207,11 +187,6 @@ def assign_issue(issue_id: int, assignee_id: int, db: Session = Depends(get_db)) issue = db.query(models.Issue).filter(models.Issue.id == issue_id).first() if not issue: raise HTTPException(status_code=404, detail="Issue not found") - update_data = issue_update.model_dump(exclude_unset=True) - if "issue_type" in update_data or "issue_subtype" in update_data: - new_type = update_data.get("issue_type", issue.issue_type) - new_subtype = update_data.get("issue_subtype", issue.issue_subtype) - _validate_issue_type_subtype(new_type, new_subtype, require_subtype="issue_type" in update_data) user = db.query(models.User).filter(models.User.id == assignee_id).first() if not user: raise HTTPException(status_code=404, detail="User not found") @@ -266,11 +241,6 @@ def add_tag(issue_id: int, tag: str, db: Session = Depends(get_db)): issue = db.query(models.Issue).filter(models.Issue.id == issue_id).first() if not issue: raise HTTPException(status_code=404, detail="Issue not found") - update_data = issue_update.model_dump(exclude_unset=True) - if "issue_type" in update_data or "issue_subtype" in update_data: - new_type = update_data.get("issue_type", issue.issue_type) - new_subtype = update_data.get("issue_subtype", issue.issue_subtype) - _validate_issue_type_subtype(new_type, new_subtype, require_subtype="issue_type" in update_data) current = set(issue.tags.split(",")) if issue.tags else set() current.add(tag.strip()) current.discard("") @@ -284,11 +254,6 @@ def remove_tag(issue_id: int, tag: str, db: Session = Depends(get_db)): issue = db.query(models.Issue).filter(models.Issue.id == issue_id).first() if not issue: raise HTTPException(status_code=404, detail="Issue not found") - update_data = issue_update.model_dump(exclude_unset=True) - if "issue_type" in update_data or "issue_subtype" in update_data: - new_type = update_data.get("issue_type", issue.issue_type) - new_subtype = update_data.get("issue_subtype", issue.issue_subtype) - _validate_issue_type_subtype(new_type, new_subtype, require_subtype="issue_type" in update_data) current = set(issue.tags.split(",")) if issue.tags else set() current.discard(tag.strip()) current.discard("") diff --git a/app/models/models.py b/app/models/models.py index b10e369..207f16d 100644 --- a/app/models/models.py +++ b/app/models/models.py @@ -1,4 +1,4 @@ -from sqlalchemy import Column, Integer, String, Text, DateTime, ForeignKey, Enum, Boolean, JSON +from sqlalchemy import Column, Integer, String, Text, DateTime, ForeignKey, Enum, Boolean, JSON, Time from sqlalchemy.orm import relationship from sqlalchemy.sql import func from app.core.config import Base