From 39da27301af244e56e0b2321aef43383e90abc3b Mon Sep 17 00:00:00 2001 From: Zhi Date: Thu, 12 Mar 2026 23:26:20 +0000 Subject: [PATCH] fix: generate milestone_code in milestones.py --- app/api/routers/milestones.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/app/api/routers/milestones.py b/app/api/routers/milestones.py index ea2af22..0dee706 100644 --- a/app/api/routers/milestones.py +++ b/app/api/routers/milestones.py @@ -45,13 +45,21 @@ def list_milestones(project_id: int, db: Session = Depends(get_db), current_user def create_milestone(project_id: int, milestone: schemas.MilestoneCreate, db: Session = Depends(get_db), current_user: models.User = Depends(get_current_user_or_apikey)): """Create a new milestone for a project.""" check_project_role(db, current_user.id, project_id, min_role="mgr") + + # Generate milestone_code: projCode:{i:05x} + project = db.query(models.Project).filter(models.Project.id == project_id).first() + project_code = project.project_code if project else f"P{project_id}" + max_ms = db.query(Milestone).filter(Milestone.project_id == project_id).order_by(Milestone.id.desc()).first() + next_num = (max_ms.id + 1) if max_ms else 1 + milestone_code = f"{project_code}:{next_num:05x}" + data = milestone.model_dump() # Handle JSON fields if data.get("depend_on_milestones"): data["depend_on_milestones"] = json.dumps(data["depend_on_milestones"]) if data.get("depend_on_tasks"): data["depend_on_tasks"] = json.dumps(data["depend_on_tasks"]) - db_milestone = Milestone(project_id=project_id, **data) + db_milestone = Milestone(project_id=project_id, milestone_code=milestone_code, **data) db.add(db_milestone) db.commit() db.refresh(db_milestone)