zhi/HarborForge.Backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: milestones router use Milestone model correctly

Browse Source
This commit is contained in:
Zhi
2026-03-12 12:33:41 +00:00
parent 4a32ed921a
commit 2e14077668
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/api/routers/milestones.py
View File

@@ -17,7 +17,7 @@ router = APIRouter(prefix="/projects/{project_id}/milestones", tags=["Milestones
def list_milestones(project_id: int, db: Session = Depends(get_db), current_user: models.User = Depends(get_current_user_or_apikey)): def list_milestones(project_id: int, db: Session = Depends(get_db), current_user: models.User = Depends(get_current_user_or_apikey)):
"""List all milestones for a project.""" """List all milestones for a project."""
check_project_role(db, current_user.id, project_id, min_role="viewer") check_project_role(db, current_user.id, project_id, min_role="viewer")
milestones = db.query(Milestone).filter(models.Milestone.project_id == project_id).all() milestones = db.query(Milestone).filter(Milestone.project_id == project_id).all()
return milestones return milestones
@@ -36,7 +36,7 @@ def create_milestone(project_id: int, milestone: schemas.MilestoneCreate, db: Se
def get_milestone(project_id: int, milestone_id: int, db: Session = Depends(get_db), current_user: models.User = Depends(get_current_user_or_apikey)): def get_milestone(project_id: int, milestone_id: int, db: Session = Depends(get_db), current_user: models.User = Depends(get_current_user_or_apikey)):
"""Get a milestone by ID.""" """Get a milestone by ID."""
check_project_role(db, current_user.id, project_id, min_role="viewer") check_project_role(db, current_user.id, project_id, min_role="viewer")
milestone = db.query(Milestone).filter(models.Milestone.id == milestone_id, models.Milestone.project_id == project_id).first() milestone = db.query(Milestone).filter(Milestone.id == milestone_id, Milestone.project_id == project_id).first()
if not milestone: if not milestone:
raise HTTPException(status_code=404, detail="Milestone not found") raise HTTPException(status_code=404, detail="Milestone not found")
return milestone return milestone
@@ -46,7 +46,7 @@ def get_milestone(project_id: int, milestone_id: int, db: Session = Depends(get_
def update_milestone(project_id: int, milestone_id: int, milestone: schemas.MilestoneUpdate, db: Session = Depends(get_db), current_user: models.User = Depends(get_current_user_or_apikey)): def update_milestone(project_id: int, milestone_id: int, milestone: schemas.MilestoneUpdate, db: Session = Depends(get_db), current_user: models.User = Depends(get_current_user_or_apikey)):
"""Update a milestone.""" """Update a milestone."""
check_project_role(db, current_user.id, project_id, min_role="mgr") check_project_role(db, current_user.id, project_id, min_role="mgr")
db_milestone = db.query(Milestone).filter(models.Milestone.id == milestone_id, models.Milestone.project_id == project_id).first() db_milestone = db.query(Milestone).filter(Milestone.id == milestone_id, Milestone.project_id == project_id).first()
if not db_milestone: if not db_milestone:
raise HTTPException(status_code=404, detail="Milestone not found") raise HTTPException(status_code=404, detail="Milestone not found")
for key, value in milestone.model_dump(exclude_unset=True).items(): for key, value in milestone.model_dump(exclude_unset=True).items():
@@ -60,7 +60,7 @@ def update_milestone(project_id: int, milestone_id: int, milestone: schemas.Mile
def delete_milestone(project_id: int, milestone_id: int, db: Session = Depends(get_db), current_user: models.User = Depends(get_current_user_or_apikey)): def delete_milestone(project_id: int, milestone_id: int, db: Session = Depends(get_db), current_user: models.User = Depends(get_current_user_or_apikey)):
"""Delete a milestone.""" """Delete a milestone."""
check_project_role(db, current_user.id, project_id, min_role="admin") check_project_role(db, current_user.id, project_id, min_role="admin")
db_milestone = db.query(Milestone).filter(models.Milestone.id == milestone_id, models.Milestone.project_id == project_id).first() db_milestone = db.query(Milestone).filter(Milestone.id == milestone_id, Milestone.project_id == project_id).first()
if not db_milestone: if not db_milestone:
raise HTTPException(status_code=404, detail="Milestone not found") raise HTTPException(status_code=404, detail="Milestone not found")
db.delete(db_milestone) db.delete(db_milestone)