nav/Fabric.Backend.Center
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(cli): set-admin transaction uses isAdmin=true filter (TypeORM rejects empty-where)

Browse Source 
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
hanghang zhang
2026-05-22 22:25:06 +01:00
parent 06756af8bc
commit bd53813391
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/auth/auth.service.ts
View File

@@ -226,10 +226,12 @@ export class AuthService {
if (!target) { if (!target) {
throw new UnauthorizedException(`user ${email} not found`); throw new UnauthorizedException(`user ${email} not found`);
} }
// Enforce at-most-one-admin: clear every other row first, then set // Enforce at-most-one-admin: clear every existing admin row first
// (TypeORM rejects an empty-where update, so target by isAdmin=true
// — the no-op cost when no rows match is one cheap query), then set
// the target. Two UPDATEs in one txn so a peer never sees two admins. // the target. Two UPDATEs in one txn so a peer never sees two admins.
await this.userRepo.manager.transaction(async (txn) => { await this.userRepo.manager.transaction(async (txn) => {
await txn.update(User, {}, { isAdmin: false }); await txn.update(User, { isAdmin: true }, { isAdmin: false });
await txn.update(User, { id: target.id }, { isAdmin: true }); await txn.update(User, { id: target.id }, { isAdmin: true });
}); });
await this.audit.write({ await this.audit.write({