nav/Dirigent
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(turn): preserve mention override during membership refresh #17

Merged
hzhang merged 2 commits from debug/mention-override-reset into feat/split-tools-and-mention-override 2026-03-08 08:02:13 +00:00
Conversation 0 Commits 2 Files Changed 2 +75 -4
orion commented 2026-03-08 08:01:40 +00:00
Collaborator
Copy Link

What

Fix mention override being clobbered by repeated ensureTurnOrder/initTurnOrder membership refreshes.

Changes

  • In initTurnOrder, compare membership against savedTurnOrder when mention override is active (instead of temporary override turnOrder).
  • When override is active and membership changes, update only savedTurnOrder and keep current override turnOrder/currentSpeaker intact.
  • Keep non-mention behavior unchanged (existing re-init-to-dormant semantics).

Validation

Reproduced channel issue where @nav was answered by neon due to override reset; with this patch, mention routing remained stable and test passed.

## What Fix mention override being clobbered by repeated ensureTurnOrder/initTurnOrder membership refreshes. ## Changes - In `initTurnOrder`, compare membership against `savedTurnOrder` when mention override is active (instead of temporary override `turnOrder`). - When override is active and membership changes, update only `savedTurnOrder` and keep current override `turnOrder/currentSpeaker` intact. - Keep non-mention behavior unchanged (existing re-init-to-dormant semantics). ## Validation Reproduced channel issue where @nav was answered by neon due to override reset; with this patch, mention routing remained stable and test passed.
orion added 2 commits 2026-03-08 08:01:40 +00:00
debug(turn): add mention-override and ensureTurnOrder state transition logs a995b7d6bf
fix(turn): keep mention override speaker/order when membership refresh runs 7e0f187f34
hzhang merged commit e5158cf039 into feat/split-tools-and-mention-override 2026-03-08 08:02:13 +00:00
hzhang deleted branch debug/mention-override-reset 2026-03-08 08:02:13 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
orion zhi nav
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: nav/Dirigent#17
Delete Branch "debug/mention-override-reset"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?