Compare commits
1 Commits
037e92b421
...
fix/bridge
| Author | SHA1 | Date | |
|---|---|---|---|
| 453dab3271 |
@@ -18,6 +18,45 @@ const SERVER_KEY = "_contractorAgentBridgeServer";
|
|||||||
/** Key for the live OpenClaw config accessor (getter fn) shared via globalThis. */
|
/** Key for the live OpenClaw config accessor (getter fn) shared via globalThis. */
|
||||||
const OPENCLAW_CONFIG_KEY = "_contractorOpenClawConfig";
|
const OPENCLAW_CONFIG_KEY = "_contractorOpenClawConfig";
|
||||||
|
|
||||||
|
/** OpenClaw replaces secret-like config values with this before exposing
|
||||||
|
* pluginConfig to plugins. */
|
||||||
|
const OPENCLAW_REDACTION_SENTINEL = "__OPENCLAW_REDACTED__";
|
||||||
|
|
||||||
|
/**
|
||||||
|
* OpenClaw redacts any secret-like key (anything containing "apiKey") before
|
||||||
|
* handing `api.pluginConfig` to the plugin, so `pluginConfig.bridgeApiKey` is
|
||||||
|
* the redaction sentinel — never the real value. The bridge server validates
|
||||||
|
* inbound requests against this key, while the OpenClaw model provider sends
|
||||||
|
* the real `models.providers.contractor-agent.apiKey`; using the redacted
|
||||||
|
* value therefore guarantees a permanent HTTP 401.
|
||||||
|
*
|
||||||
|
* Resolve the real shared secret from the raw on-disk config instead (same
|
||||||
|
* pattern `resolveAgent` already uses). If it is still missing or redacted,
|
||||||
|
* return "" so the loopback-only bridge skips auth rather than hard-locking.
|
||||||
|
*/
|
||||||
|
function resolveBridgeApiKey(fallback: string): string {
|
||||||
|
try {
|
||||||
|
const configPath = path.join(
|
||||||
|
process.env.HOME ?? "/root",
|
||||||
|
".openclaw",
|
||||||
|
"openclaw.json",
|
||||||
|
);
|
||||||
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as {
|
||||||
|
plugins?: {
|
||||||
|
entries?: Record<string, { config?: { bridgeApiKey?: string } }>;
|
||||||
|
};
|
||||||
|
};
|
||||||
|
const k = raw.plugins?.entries?.["contractor-agent"]?.config?.bridgeApiKey;
|
||||||
|
if (typeof k === "string" && k && k !== OPENCLAW_REDACTION_SENTINEL) {
|
||||||
|
return k;
|
||||||
|
}
|
||||||
|
} catch {
|
||||||
|
/* fall through to fallback handling */
|
||||||
|
}
|
||||||
|
if (fallback && fallback !== OPENCLAW_REDACTION_SENTINEL) return fallback;
|
||||||
|
return ""; // loopback-only bridge: skip auth instead of 401-locking
|
||||||
|
}
|
||||||
|
|
||||||
// ── Plugin entry ─────────────────────────────────────────────────────────────
|
// ── Plugin entry ─────────────────────────────────────────────────────────────
|
||||||
|
|
||||||
export default definePluginEntry({
|
export default definePluginEntry({
|
||||||
@@ -69,7 +108,7 @@ export default definePluginEntry({
|
|||||||
api.on("gateway_start", () => {
|
api.on("gateway_start", () => {
|
||||||
const server = createBridgeServer({
|
const server = createBridgeServer({
|
||||||
port: config.bridgePort,
|
port: config.bridgePort,
|
||||||
apiKey: config.bridgeApiKey,
|
apiKey: resolveBridgeApiKey(config.bridgeApiKey),
|
||||||
permissionMode: config.permissionMode,
|
permissionMode: config.permissionMode,
|
||||||
resolveAgent,
|
resolveAgent,
|
||||||
logger: api.logger,
|
logger: api.logger,
|
||||||
|
|||||||
@@ -596,47 +596,14 @@ export function createBridgeServer(config: BridgeServerConfig): http.Server {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
const execFn = (toolInstance as { execute: (id: string, args: unknown) => Promise<unknown> }).execute;
|
const execFn = (toolInstance as { execute: (id: string, args: unknown) => Promise<{ content?: Array<{ type: string; text?: string }> }> }).execute;
|
||||||
const toolResultRaw = await execFn(randomUUID(), toolArgs);
|
const toolResult = await execFn(randomUUID(), toolArgs);
|
||||||
|
|
||||||
// Normalize the result shape. OpenClaw plugins return one of:
|
// Extract text content from AgentToolResult
|
||||||
// (a) AgentToolResult — { content: [{type:'text', text:'...'}, ...] }
|
const text = (toolResult.content ?? [])
|
||||||
// used by tools that wrap via asContent() (e.g. all
|
.filter((c) => c.type === "text" && c.text)
|
||||||
// Dialectic.OpenclawPlugin tools).
|
.map((c) => c.text as string)
|
||||||
// (b) raw JSON-able object — { ok:true, ...domain fields }
|
.join("\n");
|
||||||
// used by tools that return data directly (e.g. every
|
|
||||||
// Fabric.OpenclawPlugin tool: fabric-channel-list,
|
|
||||||
// fabric-guild-list, fabric-send-message, etc).
|
|
||||||
// (c) null / undefined — fire-and-forget (rare).
|
|
||||||
//
|
|
||||||
// Pre-2026-05-24 the bridge ONLY handled shape (a); shape (b)
|
|
||||||
// silently returned "(no result)" to Claude Code (bug:
|
|
||||||
// fabric-channel-list and friends were unusable from contractor
|
|
||||||
// agents even though the tool actually ran successfully).
|
|
||||||
let text = "";
|
|
||||||
if (toolResultRaw == null) {
|
|
||||||
text = "";
|
|
||||||
} else if (
|
|
||||||
typeof toolResultRaw === "object" &&
|
|
||||||
Array.isArray((toolResultRaw as { content?: unknown }).content)
|
|
||||||
) {
|
|
||||||
// Shape (a)
|
|
||||||
const content = (toolResultRaw as { content: Array<{ type: string; text?: string }> }).content;
|
|
||||||
text = content
|
|
||||||
.filter((c) => c.type === "text" && c.text)
|
|
||||||
.map((c) => c.text as string)
|
|
||||||
.join("\n");
|
|
||||||
} else if (typeof toolResultRaw === "string") {
|
|
||||||
text = toolResultRaw;
|
|
||||||
} else {
|
|
||||||
// Shape (b) — serialize the whole object as JSON. Claude Code
|
|
||||||
// is happy to parse JSON tool results.
|
|
||||||
try {
|
|
||||||
text = JSON.stringify(toolResultRaw);
|
|
||||||
} catch {
|
|
||||||
text = String(toolResultRaw);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
sendJson(res, 200, { result: text || "(no result)" });
|
sendJson(res, 200, { result: text || "(no result)" });
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
|
|||||||
@@ -79,6 +79,11 @@ function install() {
|
|||||||
baseUrl: `http://127.0.0.1:${BRIDGE_PORT}/v1`,
|
baseUrl: `http://127.0.0.1:${BRIDGE_PORT}/v1`,
|
||||||
apiKey: BRIDGE_API_KEY,
|
apiKey: BRIDGE_API_KEY,
|
||||||
api: "openai-completions",
|
api: "openai-completions",
|
||||||
|
// The bridge wraps a full Claude/Gemini agent turn (tool use, multi-step),
|
||||||
|
// which routinely takes far longer than OpenClaw's default model-fetch
|
||||||
|
// timeout. Without a generous timeout OpenClaw aborts the request mid-turn
|
||||||
|
// and no reply is ever delivered. Preserve a user override if set.
|
||||||
|
timeoutSeconds: existingProvider.timeoutSeconds ?? 600,
|
||||||
models: [
|
models: [
|
||||||
{
|
{
|
||||||
id: "contractor-claude-bridge",
|
id: "contractor-claude-bridge",
|
||||||
@@ -120,11 +125,16 @@ function install() {
|
|||||||
cfg.plugins.entries[PLUGIN_ID] = cfg.plugins.entries[PLUGIN_ID] ?? {};
|
cfg.plugins.entries[PLUGIN_ID] = cfg.plugins.entries[PLUGIN_ID] ?? {};
|
||||||
cfg.plugins.entries[PLUGIN_ID].enabled = true;
|
cfg.plugins.entries[PLUGIN_ID].enabled = true;
|
||||||
|
|
||||||
// Set default config — setIfMissing so user values are preserved
|
// Set default config — setIfMissing so user values are preserved.
|
||||||
const pluginCfg = cfg.plugins.entries[PLUGIN_ID].config ?? {};
|
const pluginCfg = cfg.plugins.entries[PLUGIN_ID].config ?? {};
|
||||||
setIfMissing(pluginCfg, "bridgePort", BRIDGE_PORT);
|
setIfMissing(pluginCfg, "bridgePort", BRIDGE_PORT);
|
||||||
setIfMissing(pluginCfg, "bridgeApiKey", BRIDGE_API_KEY);
|
|
||||||
setIfMissing(pluginCfg, "permissionMode", "bypassPermissions");
|
setIfMissing(pluginCfg, "permissionMode", "bypassPermissions");
|
||||||
|
// bridgeApiKey is the shared secret between the bridge server (this plugin)
|
||||||
|
// and the model provider written above. The provider apiKey is set
|
||||||
|
// authoritatively (= BRIDGE_API_KEY); the bridge side MUST stay in lockstep
|
||||||
|
// or every request 401s. Set it authoritatively too — never setIfMissing
|
||||||
|
// (a stale prior value would desync the pair).
|
||||||
|
pluginCfg.bridgeApiKey = BRIDGE_API_KEY;
|
||||||
cfg.plugins.entries[PLUGIN_ID].config = pluginCfg;
|
cfg.plugins.entries[PLUGIN_ID].config = pluginCfg;
|
||||||
|
|
||||||
writeConfig(cfg);
|
writeConfig(cfg);
|
||||||
|
|||||||
Reference in New Issue
Block a user